search

ua-snap / mapventure

Frontend for maps built with GeoServer
2 stars 0 forks source link

Create reusable generic "Uh oh" dialog when network resources fail #302

Open brucecrevensten opened 7 years ago

brucecrevensten commented 7 years ago

There's a few places in the app which fetch dynamic data in a Promise pattern, which makes it easy to detect when the remote source has failed. But, we're not trapping the error case in most places.

To make this easier to code:

-- create a reusable "Uh oh, something went wrong" dialog box in the global scope -- Open that dialog when something goes wrong.

It's not perfect, but it's better than a hang/freeze.

brucecrevensten commented 7 years ago

Note from Craig with some newer info:

I accidentally messed up the GEOSERVER_URL environment variable on my local instance and noticed it acts like everything loaded properly after all of my GeoServer requests failed. Looks like we have an opportunity to report network errors using this new div & infrastructure. But I consider this outside the scope of this PR, and we already have an issue (#302) open for this.

brucecrevensten commented 7 years ago

The solution here is to create a new component, some kind of ErrorReporter, that can be invoked throughout the application when checking if a network resource was rejected.