search

ua-snap / mapventure

Frontend for maps built with GeoServer
3 stars 0 forks source link

Fixes #398, add copyright and version number back into footer. #427

Closed cstephen closed 7 years ago

cstephen commented 7 years ago

This change is Reviewable

cstephen commented 7 years ago

I've linked to https://www.snap.uaf.edu/expertise/expertise from the copyright text because that's what we were doing before the copyright text went missing. I'm not sure if this is still appropriate or if there's a better link target.

brucecrevensten commented 7 years ago

Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

app/scripts/app.js, line 93 at r1 (raw file):

  .run(['Analytics', function(Analytics) {}]);

app.value('version', version);

Yes, a hundred times, YES. Good fix.

Comments from Reviewable

brucecrevensten commented 7 years ago

I think that link target is good because that page functions well as a "who are these folks?" as well as linking to UAF/IARC.

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable