ua-snap / mapventure

Frontend for maps built with GeoServer
3 stars 0 forks source link

Refs #334, #403, add more loading indicators to app #430

Closed brucecrevensten closed 7 years ago

brucecrevensten commented 7 years ago

Changes here include:


This change is Reviewable

cstephen commented 7 years ago

Thoughts:

  1. The icon looks fantastic! Small nitpick here, but we could make this look a little better by reducing the width of the div so it covers less of the background image:

Instead of this:

image

We could have this:

image

I can add a commit for this change if you agree that this looks better, @bruce.

  1. I noticed some console.log() statements in the code. Should these be removed?

  2. I accidentally messed up the GEOSERVER_URL environment variable on my local instance and noticed it acts like everything loaded properly after all of my GeoServer requests failed. Looks like we have an opportunity to report network errors using this new div & infrastructure. But I consider this outside the scope of this PR, and we already have an issue (#302) open for this.

bruce commented 7 years ago

Hey folks! Love what you're doing, but you probably mean @brucecrevensten.

🍻