search

uab-cgds-worthey / DITTO

Variant Deleteriousness prediction tool using AI
GNU General Public License v3.0
1 stars 0 forks source link

Feedback on the pipeline #20

Closed ManavalanG closed 8 months ago

ManavalanG commented 1 year ago

Code used - 8e63d59ba8cd9629cd9d546a5d5a83814fd63c3b

ManavalanG commented 1 year ago

Add python and pip version to https://github.com/uab-cgds-worthey/DITTO/blob/training/configs/envs/open-cravat.yaml. Preferable to check their version in the current conda env, which was created using the current this definition file, and then pin version based on that info.

ManavalanG commented 1 year ago

Nextflow recommends storing custom scripts under bin/ directory. See here. Not necessary to follow here; more of a fyi :)

ManavalanG commented 1 year ago

I would recommend using two input samples in .test_data/file_list_partaa file instead of one. in my experience, this catches more bugs during the development/testing phase.

ManavalanG commented 1 year ago

Variable names can use a bit more clarity. For example, usage of variable files here.

  parseAnnotation.out.flatten().set { files }
  prediction(files)