search

uaf-cs / nookbot

BSD 3-Clause "New" or "Revised" License
6 stars 6 forks source link

addclasses provides incorrect error code when adding many classes #16

Closed katlyn closed 3 years ago

katlyn commented 3 years ago

The addclasses command, when provided with many classes may fail midway through adding the courses with the code Invalid CSV provided. The said error should only be returned immediately after running the command and after data validation, but review of the control flow shows that any error in adding a class will result in premature exiting of the loop and return of this error.

Quick investigation suggests that the error at hand is caused by a spotty connection to our redis instance, but overall the command needs better error handling.

katlyn commented 3 years ago

It should be noted that the underlying issue seems to be that we had reacted the maximum number of channels allowed in a category (50). The current bandaid solution is to split Math and Statistics courses into two separate categories as it was the offending subject category,