search

uafgeotools / mtuq

moment tensor uncertainty quantification
BSD 2-Clause "Simplified" License
65 stars 22 forks source link

Specfem3D-derived Green Functions expected units #230

Closed SeismoFelix closed 8 months ago

SeismoFelix commented 8 months ago

Hi @rmodrak

With @ammcpherson noticed that the example test_greens_SPECFEM3D_SAC.py is not working after the last merge. I noticed the same discrepancy after running my scripts using the latest version of MTUQ. @ammcpherson noticed that this concerns the default units expected in the SPECFEM3D-derived GFs. After the last merge, the Specfem3D-derived GFs are expected in velocity rather than displacement. The easiest solution is to change these lines of code back to displacement, but it is important to verify that this solution is compatible with the new HMC feature where SPECFEM3D_SGT-derived GFs are read.

Thanks!

Screenshot 2023-10-20 at 7 53 16 PM
rmodrak commented 8 months ago

Thanks for this report. Agreed, it would be easy to revert so that the expected units are displacement. Perhaps we should do this first as a high priority fix, then later on think about some way generalize so that both velocity and displacement can be specified at the option of the user?

rmodrak commented 8 months ago

Addressed in #233