search

uafgeotools / mtuq

moment tensor uncertainty quantification
BSD 2-Clause "Simplified" License
68 stars 23 forks source link

Parameter m0 (reference moment tensor) missing in plot_cdf #274

Open SeismoFelix opened 2 months ago

SeismoFelix commented 2 months ago

The subroutine plot_cdf requires the reference moment tensor parameter m0 for calling _calculate_pdf.

Currently, it will show the error:

omega, pdf = _calculate_pdf(df, var, m0=m0, nbins=nbins, NameError: name 'm0' is not defined

rmodrak commented 2 months ago

Good catch, thanks Felix.

On Tue, Sep 17, 2024 at 8:47 PM Félix Rodríguez Cardozo < @.***> wrote:

The subroutine plot_cdf https://github.com/rmodrak/mtuq/blob/2a558a7181c784a6b6956e01323d16b4d45d7b29/mtuq/graphics/uq/omega.py#L51 requires the reference moment tensor parameter m0 for calling _calculate_pdf https://github.com/rmodrak/mtuq/blob/2a558a7181c784a6b6956e01323d16b4d45d7b29/mtuq/graphics/uq/omega.py#L75 .

Currently, it will show the error:

omega, pdf = _calculate_pdf(df, var, m0=m0, nbins=nbins, NameError: name 'm0' is not defined

— Reply to this email directly, view it on GitHub https://github.com/uafgeotools/mtuq/issues/274, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCGSSVT33E5Z56EXMWXO7DZXDSTZAVCNFSM6AAAAABOMWBBO2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTENJXGU2TSNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rmodrak commented 2 months ago

Will add this to next PR.

On Tue, Sep 17, 2024 at 10:33 PM Ryan Modrak @.***> wrote:

Good catch, thanks Felix.

On Tue, Sep 17, 2024 at 8:47 PM Félix Rodríguez Cardozo < @.***> wrote:

The subroutine plot_cdf https://github.com/rmodrak/mtuq/blob/2a558a7181c784a6b6956e01323d16b4d45d7b29/mtuq/graphics/uq/omega.py#L51 requires the reference moment tensor parameter m0 for calling _calculate_pdf https://github.com/rmodrak/mtuq/blob/2a558a7181c784a6b6956e01323d16b4d45d7b29/mtuq/graphics/uq/omega.py#L75 .

Currently, it will show the error:

omega, pdf = _calculate_pdf(df, var, m0=m0, nbins=nbins, NameError: name 'm0' is not defined

— Reply to this email directly, view it on GitHub https://github.com/uafgeotools/mtuq/issues/274, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCGSSVT33E5Z56EXMWXO7DZXDSTZAVCNFSM6AAAAABOMWBBO2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTENJXGU2TSNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>