uafgeotools / mtuq_supp

supplement for the mtuq package
4 stars 1 forks source link

tutorial examples do not work #2

Open ArthurRodgers opened 10 months ago

ArthurRodgers commented 10 months ago

I tried to run the tutorial examples in Guide_run_MTUQ_scripts.ipynb and they run to estimate the source, but fail on plotting with "NameError: name 'trace_labels' is not defined"

I'm trying to emulate your example for a synthetic example my 3D data but was not able to run tutorial example successfully.

Also, it seems the data file naming (eventid.net.sta.loc.BH.chan [zrt]) and units (velocity in cm/sec?) is fixed. Both mtuq and mtuq_supp have strict conventions that are not clear

SeismoFelix commented 10 months ago

Hi @ArthurRodgers, thank you for trying the examples provided here. Did you update to the latest pulled version of MTUQ? The issue with trace_labels was already addressed: https://github.com/uafgeotools/mtuq/pull/233/commits/da13de39e8fa7846e205380a5a5799e8d643b248

About the unit issue, you are right. Thank you for pointing this out. This example is hard coded for working with cm or cm/s depending on whether the observed waveforms are in displacement or velocity. I will improve the example to make it flexible in that way. In the meantime, you can modify this and write, for instance, 'm' if this is the unit you are willing to work with.

Finally, for simplicity, either the physical magnitude of the observed data is displacement or velocity, the units tag preserves the displacement magnitude (i.e., 'cm' or 'm'). Therefore, in the combination tags=['units:cm', 'type:velocity'.format(data_unit)]), it is assumed that the tag 'units:cm' means that the observed data is expected in cm/s.

If the issue persists after updating MTUQ, please share the issue with a screen-shot or a detailed description of the error.

Best

ArthurRodgers commented 10 months ago

Hi Felix –

Yes! I reinstalled mtuq with the latest and this enables all the tutorial examples to run. Thanks for this I also made the small edit to mtuq_supp’s MTUQ_GridSearch_master.py

This exposed some issues with my synthetic data and GF’s but I solved these and the code ran and produced a solution, but then with some adjustment of parameters it would not run again, complaining about not be able to compare misfit for arrays of unequal size (by one sample). This may be because my fake “synthetic” data had exactly the same sample rate as the GF’s

I increased the sampling_rate on the fake data and this helped with the array size problem.

I got a result, but the amplitudes are clearly wrong. Input Mw is 5.5 but inversions wants a much smaller Mw by about 1 MW unit.

Also stations CMB and ISA at azimuth of 204 and 221 degrees, respectively, are plotted at the wrong locations on the focal sphere.

Anyhow, I’ve made some progress but still not able to run a proper correct verification test.

I’m open to suggestions on what else to try.

Thanks, Artie

From: Félix Rodríguez Cardozo @.> Reply-To: uafgeotools/mtuq_supp @.> Date: Tuesday, November 7, 2023 at 5:02 PM To: uafgeotools/mtuq_supp @.> Cc: Artie Rodgers @.>, Mention @.***> Subject: Re: [uafgeotools/mtuq_supp] tutorial examples do not work (Issue #2)

Hi @ArthurRodgershttps://urldefense.us/v3/__https:/github.com/ArthurRodgers__;!!G2kpM7uM-TzIFchu!3JyLNqmPsZaqZcxDFSXcC77Uqv0-mCOu0V3UK7tSSyy1Z6PCk-2algXH00yQ5JgmX1nfqGnGWWLrQwkt87DO7xsj8A$, thank you for trying the examples provided here. Did you update to the latest pulled version of MTUQ? The issue with trace_labels was already addressed: @.***https://urldefense.us/v3/__https:/github.com/uafgeotools/mtuq/commit/da13de39e8fa7846e205380a5a5799e8d643b248__;!!G2kpM7uM-TzIFchu!3JyLNqmPsZaqZcxDFSXcC77Uqv0-mCOu0V3UK7tSSyy1Z6PCk-2algXH00yQ5JgmX1nfqGnGWWLrQwkt87CeV2_OMg$

About the unit issue, you are right. Thank you for pointing this out. This example is hard coded for working with cm or cm/s depending on whether the observed waveforms are in displacement or velocity. I will improve the example to make it flexible in that way. In the meantime, you can modify thishttps://urldefense.us/v3/__https:/github.com/uafgeotools/mtuq_supp/blob/eeb533e031b5ffe045bea6384609a3da2be4aaad/tutorial/basic_grid_searches/MTUQ_GridSearch_master.py*L407__;Iw!!G2kpM7uM-TzIFchu!3JyLNqmPsZaqZcxDFSXcC77Uqv0-mCOu0V3UK7tSSyy1Z6PCk-2algXH00yQ5JgmX1nfqGnGWWLrQwkt87B6abDXqQ$ and write, for instance, 'm' if this is the unit you are willing to work with.

Finally, for simplicity, either the physical magnitude of the observed data is displacement or velocity, the units tag preserves the displacement magnitude (i.e., 'cm' or 'm'). Therefore, in the combination tags=['units:cm', 'type:velocity'.format(data_unit)]), it is assumed that the tag 'units:cm' means that the observed data is expected in cm/s.

If the issue persists after updating MTUQ, please share the issue with a screen-shot or a detailed description of the error.

Best

— Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/uafgeotools/mtuq_supp/issues/2*issuecomment-1799028914__;Iw!!G2kpM7uM-TzIFchu!3JyLNqmPsZaqZcxDFSXcC77Uqv0-mCOu0V3UK7tSSyy1Z6PCk-2algXH00yQ5JgmX1nfqGnGWWLrQwkt87AMK9Y99g$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/AD2344GRCX5WYUITGXAN4TLYDJLPJAVCNFSM6AAAAAA7A3VXASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJZGAZDQOJRGQ__;!!G2kpM7uM-TzIFchu!3JyLNqmPsZaqZcxDFSXcC77Uqv0-mCOu0V3UK7tSSyy1Z6PCk-2algXH00yQ5JgmX1nfqGnGWWLrQwkt87AgyhNlVw$. You are receiving this because you were mentioned.Message ID: @.***>