search

uafgeotools / rtm

A Python package for locating infrasound sources using reverse time migration
https://uaf-rtm.readthedocs.io/
MIT License
38 stars 13 forks source link

Potential problems using fill_value=0 in st.trim() #4

Closed liamtoney closed 4 years ago

liamtoney commented 5 years ago

Original report by me.

Using a value of 0 will cause problems if we're using a product-based stacking approach since it will zero the entire stack. This should be really obvious in the stack function, but is still non-ideal. One solution would be to use fill_value=np.nan instead in conjunction with np.nansum() and np.nanprod() but the presence of NaNs in a Stream is likely to crash ObsPy functions such as filtering, etc.

liamtoney commented 5 years ago

Downloading enough data may make this a non-issue, see #11

liamtoney commented 4 years ago

Probably a non-issue now. Closing.