search

uafrica / oauth-server

OAuth Server
Other
51 stars 51 forks source link

Cakephp3 header format (adopted to coding standards) #19

Closed klickagent closed 9 years ago

klickagent commented 9 years ago

Cakephp3 accepts header in different notation than the oAuth2 package (league/oauth2-server). HTTP/1.1 400 Bad Request should be HTTP/1.1 400: Bad Request in Cakephp3 in order not to cause an error in the header method of Network/Respone.

dakota commented 9 years ago

Still not passing coding standards (https://travis-ci.org/uafrica/oauth-server/jobs/71761068)

You don't need to create a new PR, just push the new commits to your branch and Github will keep the PR up-to-date.

klickagent commented 9 years ago

I never worked with Travis CI, where exactly do I find the coding conventions?

dakota commented 9 years ago

Here are the latest coding standard failures: https://travis-ci.org/uafrica/oauth-server/jobs/71776251#L239

This plugin follows the PSR-2 standard.

klickagent commented 9 years ago

Thanks for your help. I finally managed it to make the code following all conventions ;)

dakota commented 9 years ago

Implemented in https://github.com/uafrica/oauth-server/commit/efe4c0a4b5b9645cb9a2a57e561d4303c0364bee

Thanks for the fix! :100: