search

uaktags / explorer

An open source block explorer
BSD 3-Clause "New" or "Revised" License
6 stars 8 forks source link

Empty Search #11

Closed spy0012 closed 5 years ago

spy0012 commented 5 years ago

I have noticed if you press search with nothing in the box you get a page isn't working and the address bar showing

/block/[object%20Object] Normally it would show an error text saying no results found i am assuming this from translation should kick in error": "Error! - {{error}} Unmodified explorer is - "ex_search_error": "Search found no results for: ",

uaktags commented 5 years ago

Presumably this is an issue in https://github.com/uaktags/explorer/blob/master/routes/index.js starting at line 303. I'll take a look later and see what I see.

spy0012 commented 5 years ago

Looks like Dstra never got this working either, checked the code and matches, and fails as such too, but all explorers in .jade work fine

uaktags commented 5 years ago

Yea, i doubt its with pug/jade, just something in the backend not being handled properly. I'm a little swamped today but i'll get to it in the next 3-4hours.

uaktags commented 5 years ago

Found some extra time. Give that a gander and see if that resolves it for you!

spy0012 commented 5 years ago

image

Great it works, thank you hoping i am not rushing you as i know you are doing the explorer at your own pace and don't want to take you away from other work.

Appreciate the fixes

uaktags commented 5 years ago

No worries. I may soon adapt that message for when it's empty to say it's empty, but it should work if you put in a string and say "Search found no results: alsdfkjaldkfj".