ualberta-smr / LibCompPlugin

An IntelliJ plugin for comparing libraries
http://smr.cs.ualberta.ca/comparelibraries
MIT License
6 stars 1 forks source link

Fix charts displayed in plugin #15

Closed relhajj closed 4 years ago

relhajj commented 4 years ago

I noticed that a lot of charts were missing in the SMR DB so I have updated those, now all of the images found in https://github.com/ualberta-smr/librarycomparisonswebsite/tree/master/charts are also in the SMR DB and are properly labelled.

I have kept this script and will add it to my new PR coming soon so that we can keep it for future use when we need to upload new charts to the DB (it converts to png, labels the images with the name Chart-domainID_metricID and then uploads into the DB with the proper domain and metric ID labels.

I noticed also that there were some issues on my part for how I am displaying the images in the dialogue. The problem is that some images are being mapped incorrectly due to the ID changes that occurred when we switched to using API's, I will need to re-map images to the dialogue and fix this.

Also, some images are simply non-existent for particular domain-metric pairs. As of now, these charts/images, if missing, cause the button to be disabled so if you click the chart button for a chart that does not exist nothing happens. I think a better thing to do would be to have either a "default image" or even a message with something like "we do not have a chart to display information for this domain/metric at this time".