search

ualberta-smr / LibCompPlugin

An IntelliJ plugin for comparing libraries
http://smr.cs.ualberta.ca/comparelibraries
MIT License
6 stars 1 forks source link

Colors make things not visible #18

Closed snadi closed 4 years ago

snadi commented 4 years ago

If I click on a metric value by mistake, this is what I get:

image

Can we make the metrics not clickable to avoid this, unless they are expected to do something?

Also, I just noticed that I can't seem to see the replace button

snadi commented 4 years ago

So turns out the buttons are there but not visible (just clicked around and actually hit something).. I'm not sure if this is because I have my IDE as dark mode. I'm wondering if instead of hard-coding colors, there's a way to adapt them from the IDE's current look and feel

relhajj commented 4 years ago

"All plugins should declare a dependency on com.intellij.modules.platform as an indication of dependence on shared functionality." https://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/plugin_compatibility.html..

(maybe related to UI bug because this dependency gives access to UI themes etc)

--- May need to add dependency to build.gradle file for UI dependency

relhajj commented 4 years ago

Metrics is no longer clickable

In terms of the replace button, I believe you still won't be able to see it - the goal was that you can ONLY see the replace button when you click an alternative library (so if you click the current library and/or the metrics column you should not be able to replace, another option could be to "grey out" the button instead of completely remove it when they click an invalid replacement)

snadi commented 4 years ago

Issue addressed in PR #32