Relhajj bugs - Githubissues

ualberta-smr / LibCompPlugin

An IntelliJ plugin for comparing libraries

http://smr.cs.ualberta.ca/comparelibraries

MIT License

6 stars 1 forks source link

Relhajj bugs #35

Closed relhajj closed 4 years ago

relhajj commented 4 years ago

This PR deals with solving several issues below:

closes #21
closes #25
closes #27
closes #28
closes #34
closes #16

Also, when reviewing you might benefit from filtering to only see the .java files as those are what changed.

snadi commented 4 years ago

@relhajj I have merged the PR on the server and now the maven url should be returned by the API. However, note that you should also open a PR in the LibraryMetricScripts repo to update:

https://github.com/ualberta-smr/LibraryMetricScripts/blob/master/scripts/SharedFiles/LibraryData.json -- add field there for each entry
https://github.com/ualberta-smr/LibraryMetricScripts/blob/master/scripts/addlibraries.py to add that entry for future libraries or if we reset the DB
https://github.com/ualberta-smr/LibraryMetricScripts/blob/master/librarycomparison/models.py to have the same model as the website (till we find an easier way to avoid having this model in two places)