Add a comment explaining reason for or

ualberta-smr / merganser

Merganser is a scalable and extendable tool for analyzing merge scenarios in git repositories

https://ualberta-smr.github.io/merganser/

MIT License

7 stars 1 forks source link

Add a comment explaining reason for or #16

Open snadi opened 6 years ago

snadi commented 6 years ago

Document reason for or (mentioning the weird scenario you ran to if you can look it up)

https://github.com/ualberta-smr/code-owhadi-msr19/blob/1724d8a2ff6b334c0775a8498359ce892249d320/merge_excavator/code_quality.py#L28

mkareshk commented 6 years ago

@snadi I couldn't remember the reason that I used both criteria, but since both of them are consistent with each other, I think we can keep them; correct?

snadi commented 6 years ago

Yeah, they are consistent. It's just a bit weird that you need both. I don't know if there are special cases when the process get interrupted for example and thus there is no BUILD FAILURE in the l og, but there is also no BUILD SUCCESS. Would that then get incorrectly counted as success?