search

ualbertalib / DMP_roadmap

DCC/UC3 collaboration for a data management planning tool
MIT License
1 stars 3 forks source link

Adding docker #6

Closed alexstrilets closed 7 years ago

weiweishi commented 7 years ago

Thank you!

If now you could address the comment re:db:migrate in the deployment, I will be okay to prove it.

Weiwei Shi

Digital Initiative Applications Librarian University of Alberta Libraries 2-10L Cameron Library Edmonton, Alberta, Canada T6G 2J8 Phone:(780)492-7802 Fax: (780)248-1209 Email: weiwei.shi@ualberta.ca

On Wed, Oct 18, 2017 at 4:06 PM, Alex Strilets notifications@github.com wrote:

@astrilet commented on this pull request.

In docker-compose.yml https://github.com/ualbertalib/DMP_roadmap/pull/6#discussion_r145556106:

  • environment:
    • MYSQL_ROOT_PASSWORD=${DB_PASSWORD}
    • MYSQL_DATABASE=roadmap
  • healthcheck:
  • test: mysqladmin -uroot -p${DB_PASSWORD} ping && [ -e /var/lib/mysql/roadmap ]
  • interval: 5s
  • timeout: 5s
  • retries: 100
  • volumes:
    • db:/var/lib/mysql
  • web:
  • build: .
  • image: ualbertalib/dmp_roadmap
  • env_file: .env

OK change .env file to keep ALL environment variables there, this makes more sense

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ualbertalib/DMP_roadmap/pull/6#discussion_r145556106, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8-fkNdg-pkSHVMH7CuIqC1LrFCkEsHks5stnZigaJpZM4OUIJu .

weiweishi commented 7 years ago

@astrilet Also missing from this is to set the Devise.secret_key run into this issue:

web_1  | rake aborted!
web_1  | Devise.secret_key was not set. Please add the following to your Devise initializer:

you'd either need to change the devise configuration file to read this in from env var, or a rails secrets.yml file.