search

ualbertalib / Hydranorth2

[deprecated] Sufia 7 based application
1 stars 2 forks source link

small config changes; added env variable to enable temp login in prod… #145

Closed alexstrilets closed 7 years ago

alexstrilets commented 7 years ago

1 config changes 2 added env variable ENABLE_TMP_LOGINS to enable temp logins in production mode 3 added Dockerfile to build docker image

weiweishi commented 7 years ago

@astrilet I've found this comment here https://github.com/docker/compose/issues/374:

Here's a way to do it with healthcheck and docker-compose 2.1+:

version: "2.1" services: db: image: mysql:5.7 environment: MYSQL_ROOT_PASSWORD: password healthcheck: test: mysqladmin -uroot -ppassword ping interval: 2s timeout: 5s retries: 30 web: image: nginx:latest # your image depends_on: db: condition: service_healthy Here docker-compose up will start the web container only after the db container is considered healthy.

This can probably be investigated and incorporated in if possible to avoid the use of additional script.

weiweishi commented 7 years ago

Please also update your PR description to include the Dockerfile change.