Closed sfarnel closed 3 years ago
May not be relevant pending outcome of #22 Also need to determine if this is a data issue or an issue with the application
@sfarnel @danydvd
As far as I know, all we have for the moment are the acronyms. We'd either have to add the full degree name to each record in the SOLR index, or we could define a mapping that is used dynamically (like we do with the universities).
Thanks @jchartrand
For @danydvd let's see what we can do about this via some data cleanup (I think dynamic list is the best if possible)
@sfarnel @jchartrand currently I am using the following for mapping degrees into SOLR:
solr_deg_map = { "msc": "MSc", "phd": "PhD", "med": "MEd", "ma": "MA", "master": "Master", "meng": "MEng", "mn": "MN", "llm": "LLM", "masc": "MASc", "msw": "MSW", "mba": "MBA", "mws": "MWS", "menv": "MEnv", "mphysed": "MPhysEd", "march": "MArch", "mfa": "MFA", "lld": "LLD", "mcoun": "MCoun", "mmath": "MMath", "dba": "DBA", "des": "Dec", "dsc": "DSc", "maed": "MAEd", "mdent": "MDent", "mdes": "MDes", "mhstud": "MHStud" }
I am using this to make the degree acronyms more readable (but they are still acronyms). I can add another value with full degree names (e.g. `"msc": ["acronym": "MSc", "value": "Master of Science"], ...). Would this work for pulling the full name in the react?
I’m not sure I understand.
Would you add a new field to each SOLR record, called something like:
degree_full (with corresponding degree_full_str)
that contains the expanded degree name?
And the degree (and degree_str) would stay as they are now, with the acronyms?
If so, that would work for me.
(Or possibly even better, put the expanded degree name in ‘degree’ and the acronym in ‘degree_acronym’)
On Sep 17, 2020, at 1:47 PM, Danoosh Davoodi notifications@github.com wrote:
@sfarnel https://github.com/sfarnel @jchartrand https://github.com/jchartrand currently I am using the following for mapping degrees into SOLR:
solr_deg_map = { "msc": "MSc", "phd": "PhD", "med": "MEd", "ma": "MA", "master": "Master", "meng": "MEng", "mn": "MN", "llm": "LLM", "masc": "MASc", "msw": "MSW", "mba": "MBA", "mws": "MWS", "menv": "MEnv", "mphysed": "MPhysEd", "march": "MArch", "mfa": "MFA", "lld": "LLD", "mcoun": "MCoun", "mmath": "MMath", "dba": "DBA", "des": "Dec", "dsc": "DSc", "maed": "MAEd", "mdent": "MDent", "mdes": "MDes", "mhstud": "MHStud" }
I am using this to make the degree acronyms more readable (but they are still acronyms). I can add another value with full degree names (e.g. `"msc": ["acronym": "MSc", "value": "Master of Science"], ...). Would this work for pulling the full name in the react?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/11#issuecomment-694395388, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFSXOCXOCCDCGDEMJ5MDLSGJDS5ANCNFSM4P75JP3Q.
I was thinking of a mapping file similar to (institutions.json) but it might make more sense to add a field in SOLR (which still have to use the mapping file to map the acronym to full degree name).
An extra SOLR field would definitely be easier for me, and would remove that extra moving part of an XHR call from the app to get the mapping file, and also anything that might go wrong with the mapping file.
I suppose that is also true for the institutions.json - if that stuff could be added directly to each SOLR record, it would probably make everything easier, clearer, and less prone to breakage.
On Sep 17, 2020, at 2:44 PM, Danoosh Davoodi notifications@github.com wrote:
I was thinking of a mapping file similar to (institutions.json) but it might make more sense to add a field in SOLR (which still have to use the mapping file to map the acronym to full degree name).
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/11#issuecomment-694426892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFSXMUB6EZ2U6ZLW2RXN3SGJKILANCNFSM4P75JP3Q.
That make sense. So for the next index I will add the following fields:
Thanks both. I will compile the list (which will need to be added to easily) and send along
@danydvd full degree names below. Please note that I flagged a few where I need an example to be sure what it is. Thanks!
Full names:
MSc: Master of Science
PhD: Doctor of Philosophy
MEd: Master of Education
MA: Master of Arts
MEng: Master of Engineering
MN: examples needed
LLM: Master of Laws
MASc: Master of Arts in Science
MSW: Master of Social Work
MBA: Master of Business Administration
MWS: Master of Water Security
MEnv: Master of Environmental Assessment
MPhysEd: Master of Physical Education
MArch: Master of Architecture
MFA: Master of Fine Arts
LLD: Doctor of Laws
MCoun: Master of Counselling
MMath: Master of Mathematics
DBA: Doctor of Business Administration
Des (or Dec?) - fix acronym: should this be ddes (Doctor of Design)? can we have some examples needed
DSc: Doctor of Science
MAEd: Master of Arts in Education
MDent: Master of Dentistry
MDes: Master of Design
MHStud: examples needed
Master: Master
@danydvd I notice also that there are some degree acronyms that do not appear in the list you provided. For example if you do a search for virtual reality and look at the degrees, you'll see one like med and sjd. Can you provide a complete list of all of these with a link to the item so I can review? Many thanks! :)
@sfarnel here is the report for degrees. full report: https://drive.google.com/file/d/1LyJ83OUZd9xA2_faaPoLCOqIxFOQmP4n/view?usp=sharing distinct: https://drive.google.com/file/d/1fgtVG0smhz8EYiX09MtTcxWdu_saTo_I/view?usp=sharing
Thanks @danydvd I will review and get back to you!
@danydvd file with full names attached: https://drive.google.com/file/d/1r8iNU17mj_hLDO3e4ZIYxw3YzUj4Mgb3/view?usp=sharing (Note one example I couldn't find as I couldn't seem to access the examples)
@jchartrand
have been added to the new index (CanLink-new-5)
@sfarnel
The short university names and the expanded degree names were both to be used for their respective legends (I think?) in the bubble visualizations.
So, with the legends removed, should I at least put the short university names in the bubbles (so more bubbles can show the university names)?
Should I do anything with the full degree names? If I put them in the bubbles, then we'd probably see fewer bubbles with the degree visible. One option could be to leave the degree abbreviation in the bubble, and I could add a click on the bubble that would show the full degree name. Of course the end user would have to know to click. Adding the click would probably take an hour or two.
Thanks @jchartrand
Clicking is not necessary as we have hover over on both and this is fine for now
I'll also use the expanded names elsewhere - details model, record page (unless you say otherwise).
@danydvd Above you say the new index is CanLink-new-5 but I also see a CanLink-new-6 in SOLR.
Just wanted to confirm 5 is correct?
@jchartrand re: expanded names elsewhere as well, yes please; thanks!
@jchartrand Yes I am adding some more fields (i.e. subject URLs). I will create separate ticket for that. So yes CanLink-new-5 is the correct one.
I've updated the bubbles to use the shorter university names, and I've updated all uses of degree names to show the expanded versions. I think I found all uses, but just let me know if I missed one.
Thanks @jchartrand
Flag for @danydvd there is a typo in Master of Science (Science is missing the 'i'); see image below. My bad! If you can fix asap that would be great, thanks!
@sfarnel thank you noticing this. The typo is corrected in the mapping and a new index will resolve this.
Issue addressed. Closing
On this view the degree names are just the acronyms which may not be helpful to a user. Could the legend (to the right) use a fuller form?