search

ualbertalib / can-link

Front end react app for CanLink project
1 stars 0 forks source link

Color and Font Specs for content #36

Closed CarlsoFiorention closed 3 years ago

CarlsoFiorention commented 4 years ago

Please use these specs guidelines for visual consistency

specs copy.pdf

jchartrand commented 3 years ago

@sfarnel @CarlsoFiorention

You list two font options in the 'specs copy.pdf' file (https://github.com/jchartrand/can-link/files/5132755/specs.copy.pdf):

News Gothic Medium

or

News Cycle Medium

and say the second (News Cycle Medium) is open source.

I'm not sure what are the implications of the open source vs non open source ?

Would we, for example, have to pay for the News Gothic Medium?

This seems probably like a discussion for Carlos and Sharon?

sfarnel commented 3 years ago

Thanks James. @CarlsoFiorention can you provide details on options and implications? We certainly do not want to be in a scenario where we need to pay for usage. Thanks!

CarlsoFiorention commented 3 years ago

News Gothic may be free via institutions (I already have it free from U of A), News Cycle is free to everyone for sure.

On Sep 1, 2020, at 12:41 PM, James Chartrand notifications@github.com wrote:

@sfarnel https://github.com/sfarnel @CarlsoFiorention https://github.com/CarlsoFiorention You list two font options in the 'specs copy.pdf' file (https://github.com/jchartrand/can-link/files/5132755/specs.copy.pdf https://github.com/jchartrand/can-link/files/5132755/specs.copy.pdf):

News Gothic Medium

or

News Cycle Medium

and say the second (News Cycle Medium) is open source.

I'm not sure what are the implications of the open source vs non open source ?

Would we, for example, have to pay for the News Gothic Medium?

This seems probably like a discussion for Carlos and Sharon?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/36#issuecomment-685061024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFMUPMR2OGBNJC64DAJB4DSDU55LANCNFSM4QMIBF6A.

jchartrand commented 3 years ago

Should we just go with News Cycle to be safe?

If so, then just to be sure, is this it:

https://fonts.google.com/specimen/News+Cycle

?

And this should be used everywhere in the site?

CarlsoFiorention commented 3 years ago

Yes, that’s correct, that’s the right one, the regular 400, and we will use it for everything in the site. Eventually, we may need the bold and italic variables in the future.

On Sep 1, 2020, at 1:38 PM, James Chartrand notifications@github.com wrote:

Should we just go with News Cycle to be safe?

If so, then just to be sure, is this it:

https://fonts.google.com/specimen/News+Cycle https://fonts.google.com/specimen/News+Cycle ?

And this should be used everywhere in the site?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/36#issuecomment-685089783, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFMUPOJKRZURFEV5YP7EIDSDVEUNANCNFSM4QMIBF6A.

sfarnel commented 3 years ago

Sounds great; thanks both!

jchartrand commented 3 years ago

I've changed the global font to News Cycle, and set the default font size for body text, etc. to 10.

It will take me a bit longer to go through all the titles, etc. and change those to 12.

But, if you could take a look at confirm that things are looking as they should, that would be great.

The colours will be a fair bit harder for the visualizations etc. I'll have to do those widget by widget and I should probably wait until we are working on each of those visualizations individually.

CarlsoFiorention commented 3 years ago

Fonts look good. Changing the list of documents to size 12 may be the most relevant adjustment for now, the rest is looking good. Thank you,

On Sep 1, 2020, at 3:41 PM, James Chartrand notifications@github.com wrote:

I've changed the global font to News Cycle, and set the default font size for body text, etc. to 10.

It will take me a bit longer to go through all the titles, etc. and change those to 12.

But, if you could take a look at confirm that things are looking as they should, that would be great.

The colours will be a fair bit harder for the visualizations etc. I'll have to do those widget by widget and I should probably wait until we are working on each of those visualizations individually.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/36#issuecomment-685149180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFMUPLRLQMVRCFHPI23GUDSDVTA3ANCNFSM4QMIBF6A.

jchartrand commented 3 years ago

Okay, I've changed the document list to 12, and most everything else I could see has been changed. I may have missed some things though, so just let me know.

sfarnel commented 3 years ago

Thanks James. @CarlsoFiorention can you review with your keen eye? Thanks!

CarlsoFiorention commented 3 years ago

Just a few things on type:

jchartrand commented 3 years ago

Made the requested changes, i.e.,

Make "about, "contact" and "search" size 11 Make the widgets labels also size 11 Reduce "Page 1 of ..." to size 10

CarlsoFiorention commented 3 years ago

Looks better now, thank you

On Sep 1, 2020, at 6:49 PM, James Chartrand notifications@github.com wrote:

Made the requested changes, i.e.,

Make "about, "contact" and "search" size 11 Make the widgets labels also size 11 Reduce "Page 1 of ..." to size 10

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/36#issuecomment-685211994, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFMUPIOWUXKBGHVDYZJ6UDSDWJADANCNFSM4QMIBF6A.

sfarnel commented 3 years ago

@jchartrand it looks like the specs related to a selected item in the results list have not been implemented. can you see if anything not related to a specific widget has been done? Thanks!

jchartrand commented 3 years ago

@sfarnel Hi Sharon, I'm not sure what you mean in your last comment, i.e.,

"it looks like the specs related to a selected item in the results list have not been implemented. can you see if anything not related to a specific widget has been done? Thanks!"

sfarnel commented 3 years ago

Sorry James. I was just looking at the specs document from Carlos and noticed that he had info on come colouring for when an item is selected. That seemed to me to be unrelated to a specific widget so thought it might make sense to take care of it now before diving into specs for each widget, which you noted might make sense to do one at a time. Does that help clarify?

CarlsoFiorention commented 3 years ago

I’m keeping a list of fine tuning things to be done at the end, including the implementation of colors and issues with sizes. alignments etc. Do you want me to deliver this list rather sooner than later?

On Sep 3, 2020, at 2:38 PM, Sharon Farnel notifications@github.com wrote:

Sorry James. I was just looking at the specs document from Carlos and noticed that he had info on come colouring for when an item is selected. That seemed to me to be unrelated to a specific widget so thought it might make sense to take care of it now before diving into specs for each widget, which you noted might make sense to do one at a time. Does that help clarify?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/36#issuecomment-686752841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFMUPPLGFVMY7SLGXBUXELSD75FZANCNFSM4QMIBF6A.

jchartrand commented 3 years ago

Probably safest if you send me the text (or screen shot) the specific spec/bit that describes the colouring for the item selection? I’ll hopefully get less confused that way.

On Sep 3, 2020, at 4:38 PM, Sharon Farnel notifications@github.com wrote:

Sorry James. I was just looking at the specs document from Carlos and noticed that he had info on come colouring for when an item is selected. That seemed to me to be unrelated to a specific widget so thought it might make sense to take care of it now before diving into specs for each widget, which you noted might make sense to do one at a time. Does that help clarify?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/36#issuecomment-686752841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFSXJL6ILLXEDSIRHWYMLSD75FZANCNFSM4QMIBF6A.

sfarnel commented 3 years ago

Remaining items addressed in fine tuning issue(s); closing.