search

ualbertalib / can-link

Front end react app for CanLink project
1 stars 0 forks source link

Filter behaviour on search results page #40

Closed sfarnel closed 4 years ago

sfarnel commented 4 years ago

Related to issue #2

image

When searching from the landing page, the query opens correctly in the Search page, but the 'query' input isn't populated with the text of the query from the landing page input. This is now happening; see below.

image

However, from here, any changes a user makes in the top filters should act on the existing subset of items rather than on the collection as a whole.

For example, in the image below, the filter of date from 2013 to 2014 should limit the subset of results returned from the teeth search. Currently, it starts a new search.

image

jchartrand commented 4 years ago

I think this is all done now?

sfarnel commented 4 years ago

Noting this here in case it relates to this specific issue; if not I can create a separate one.

On landing page I did a search for research Alberta and got to the search results page. Knowing there were no results from U of Alberta, I selected it from the institution dropdown and hit Search to see what would happen. What I got back was the same list of results (which actually isn't correct as it should be zero) and the 'something went wrong message':

image

We should determine why it returned an incorrect result set and also see about having a different message (no results. to show).

sfarnel commented 4 years ago

It seems that the author and subject autosuggest are not currently working; is this the issue with the specific core?

sfarnel commented 4 years ago

Date limits don't seem to work and also throws that same 'something went wrong' error:

image

jchartrand commented 4 years ago

It could be. It might also be the reason for the ’Something went wrong…’ error you noted.

Should I push these two things to the top of my pile today? Not just to find the cause of the errors, but also to change the message?

On Sep 3, 2020, at 9:37 AM, Sharon Farnel notifications@github.com wrote:

It seems that the author and subject autosuggest are not currently working; is this the issue with the specific core?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/40#issuecomment-686497189, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFSXM46L2SGLUTHXI4W4TSD6LYRANCNFSM4QOOMWJQ.

sfarnel commented 4 years ago

Thanks @jchartrand yes, if you can, that would be great. I also created an issue yesterday (#42 ) that may be related. @danydvd if you can help with investigation that would be great so that we can make the best use of James' time as we still have some important dev items (fleshing out new fields in item level records, etc.) to attend to

jchartrand commented 4 years ago

Okay, that was my fault. I had updated the core to CanLink-new-3 on my local server, but not the alberta server.

So, the autosuggests now works (on the alberta server), although as Danoosh has pointed out, he will next get rid of the html tags in the subject suggester.

The ’Something went wrong…’ error remains though, so I will fix that next.

On Sep 3, 2020, at 9:37 AM, Sharon Farnel notifications@github.com wrote:

It seems that the author and subject autosuggest are not currently working; is this the issue with the specific core?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

jchartrand commented 4 years ago

@sfarnel I think I’ve fixed the ’Something went wrong…’ errors, which happened when a query returned no results.

Did you also want me to change the No Results To Show message, or the appearance of it, i.e.,

On Sep 3, 2020, at 9:35 AM, Sharon Farnel notifications@github.com wrote:

Noting this here in case it relates to this specific issue; if not I can create a separate one.

On landing page I did a search for research Alberta and got to the search results page. Knowing there were no results from U of Alberta, I selected it from the institution dropdown and hit Search to see what would happen. What I got back was the same list of results (which actually isn't correct as it should be zero) and the 'something went wrong message':

https://user-images.githubusercontent.com/4697932/92121784-e8473400-edb7-11ea-9217-81bcf3e0c5a3.png We should determine why it returned an incorrect result set and also see about having a different message (no results. to show).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/40#issuecomment-686496247, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFSXLWSWYVOQGICARXZD3SD6LTJANCNFSM4QOOMWJQ.

sfarnel commented 4 years ago

Thanks James. @CarlsoFiorention do you have preference for how this appears?

sfarnel commented 4 years ago

Will leave the appearance of No results to show to issues involving specific look and feel. Closing this issue (and also #42)

CarlsoFiorention commented 4 years ago

Only one suggestion to emphasize the message, could we try the font in red color?

jchartrand commented 4 years ago

Done - ’no results to show’ colour changed to red.

On Sep 3, 2020, at 1:01 PM, Carlos Fiorentino notifications@github.com wrote:

Only one suggestion to emphasize the message, could we try the font in red color?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/40#issuecomment-686626564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEFSXMYAPY5TWRQMK3EQE3SD7DXTANCNFSM4QOOMWJQ.