ualbertalib / can-link

Front end react app for CanLink project
1 stars 0 forks source link

Next Steps: Fine tuning #46

Closed sfarnel closed 3 years ago

sfarnel commented 3 years ago

These are remaining fine tuning elements to be completed before the next big chunk of work is undertaken.

Home page

(from issue #23) – Move small canlink logo (top left corner) 5 pixels down Add gradient background Move U of A library to the bottom of the cloud Eliminate any drop shadow border (from issue #36) - Color and font specs (specs.copy.pdf)

Search page and visualizations

(from issue #45) – see fine tuning specs doc (fine.tuning.pdf) (except do not move search to header, do leave map as world map) (from issue #10) – ensure University names are not cut off (from issue #11) – display full degree names (if this can be done; if you need data let me know)

Once done another review for fine-tuning will be done.

jchartrand commented 3 years ago

I am really stuck on changing the colour of the selected visualization button (from it's grey colour to blue):

image

What should work (with css, pseudo classes, the material-ui overrides, etc.), isn't.

I've already spent close to a couple of hours on this - should I cut our losses and move on to something else, or stick it out?

sfarnel commented 3 years ago

Thanks @jchartrand Let's cut our losses for the moment

jchartrand commented 3 years ago

ok. otherwise, things are going well. I've just pushed up some new changes, including the Word Cloud adjustments (font, colour, horizontal word layout, alignment).

CarlsoFiorention commented 3 years ago

Looking good!

On Sep 17, 2020, at 2:59 PM, James Chartrand notifications@github.com wrote:

ok. otherwise, things are going well. I've just pushed up some new changes, including the Word Cloud adjustments (font, colour, horizontal word layout, alignment).

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/46#issuecomment-694496595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFMUPJCWGBVHGMSDTLPWYLSGJ2CXANCNFSM4RO6SORQ.

jchartrand commented 3 years ago

I've just pushed up some more changes that include alignment and colour for the Treemap.

sfarnel commented 3 years ago

Thanks @jchartrand Looks great! Is there a way to adjust where the number of items associated with a date appears? Currently it is below the treemap and so if you're not scrolling down you don't notice it.

jchartrand commented 3 years ago

Yes, no problem - where would you like it to appear? I've also just now adjusted the font on that number of items, and added a label to describe what the number means, and to explain that you can mouseover to get values (this is not yet pushed to server; it is only on my local dev server):

image image
jchartrand commented 3 years ago

Moving the text from where it is now to up above the Treemap would be easy. Adding a mouseover popup instead (to show the counts in the popup) would take an hour or two.

sfarnel commented 3 years ago

Thanks @jchartrand Let's move it to above the treemap for now

jchartrand commented 3 years ago

I think this is all done now, except for issues #10 and #11 which are referenced here, but are also up in the project board.

sfarnel commented 3 years ago

Closing now. Issues 10 and 11 remain open, separately, pending data cleanup.