search

ualbertalib / can-link

Front end react app for CanLink project
1 stars 0 forks source link

No way to get back to home page from search results page #7

Closed sfarnel closed 4 years ago

sfarnel commented 4 years ago

Once you have left the home page (i.e., done a search) you cannot get back to the home page.

Make the CanLink logo (top left) a link to the homepage?

jchartrand commented 4 years ago

When going back to the Landing (home) page, should I restore whatever query (if any) had previously been on the Landing page?

And I'm guessing that whatever is in the query form on the Search page should remain there if someone comes back to the Search page, unless a new query is issued from the Landing page, in which the search page will show only what came from the Landing page.

Described as a scenario:

  1. I first open the can link site which takes me to Landing page.
  2. I issue a query from there ('hamilton cycling')
  3. That takes me to the Search page, populates the query with 'hamilton cycling' and issues it, returning results.
  4. I then select a subject in the subject dropdown, and run the new query, which shows new results.
  5. I then go to the Landing page, by clicking the CanLink Logo in the header.
  6. I see my original query - 'hamilton cycling'. (or should this be cleared)?
  7. I now issue another query like 'hamilton velodrome' which takes me to the Search page and shows results. Presumably the previously selected subject in the dropdown should be cleared?

Should anything else happen that I'm overlooking?

sfarnel commented 4 years ago

@CarlsoFiorention do you have thoughts on this based on the original designs and flow?

CarlsoFiorention commented 4 years ago

The 7 points described in the scenario are correct, that's the way I think the flow should respond based on the original design. This being said, the original design follows an "academic prototyping" idea, which suggest that while we develop the interface we may need to make some decisions on how the interface should evolve when facing unseen situations. In short, so far the overall design works, but we should keep an eye on unseen behavioral situations.

sfarnel commented 4 years ago

Thanks @CarlsoFiorention this makes good sense. @jchartrand please proceed as you outlined in your scenario.

jchartrand commented 4 years ago

I've got this working now after a lot of trouble (it has to do with how React routes pages - the good news is that the the code is a lot simpler and clearly organized now), except for point 6 above - when returning to the landing page any query that had been there has been cleared. I can definitely get this to work if it is important, but it would probably take a couple of hours.

sfarnel commented 4 years ago

I this this is great as is. Unless @CarlsoFiorention sees a reason to put in the additional time, I think we can call this one done.

sfarnel commented 4 years ago

Closing issue. Can reopen if needed

CarlsoFiorention commented 4 years ago

I think its done

On Sep 3, 2020, at 7:45 AM, Sharon Farnel notifications@github.com wrote:

I this this is great as is. Unless @CarlsoFiorention https://github.com/CarlsoFiorention sees a reason to put in the additional time, I think we can call this one done.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jchartrand/can-link/issues/7#issuecomment-686502924, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGFMUPLO2RQGPBDESUGSB2TSD6MZPANCNFSM4P746BIQ.