search

ualbertalib / discovery

Discovery is the University of Alberta Libraries' catalogue interface, built using Blacklight
http://search.library.ualberta.ca
12 stars 3 forks source link

[Discovery] More button not working #1475

Open seanluyk opened 5 years ago

seanluyk commented 5 years ago

Describe the bug Clicking on a more link from an expanded facet does not work

To Reproduce Steps to reproduce the behavior:

  1. Facet by, e.g. call number, author, etc.
  2. Click on more
  3. Notice error

Expected behavior Clicking a more link should open the popup window with A-Z and numerical sort options (compare with NEOS Blacklight)

Additional context This seems to have broken after the CMS switchover

As discussed with @seanluyk, we agree that we will change the "More" link to open a new tab to the correct URL, so at least it is functioning. We will investigate a modal solution in future work.

murny commented 5 years ago

Ran into this issue today as well! The pages work fine and if you open the more >> link in a new tab (middle mouse button/right click->open in new tab, etc) it will open fine (https://search.library.ualberta.ca/catalog/facet/language_facet).

For whatever reason theirs some javascript on the page that is preventing this page from opening returning this error:

Refused to execute script from 'https://search.library.ualberta.ca/catalog/facet/subject_topic_facet?q={{query}}&_=1548368021009' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled.

It's suppose to open as a modal window but this javascript is broken for some reason.

Don't think any of the CMS removal stuff have landed yet in discovery (we probably on this version which was before christmas: https://github.com/ualbertalib/discovery/releases/tag/3.0.94)

I suppose a super easy fix would be....just open this page as a html page...and remove the modal/js

Otherwise we need to figure out whats happening with the javascript. It might be just because the js response is coming back as text/html for whatever reason?

seanluyk commented 5 years ago

Weird, I wonder if the URL changes could be causing this?

nnunn commented 5 years ago

I can't see how it would, I'll try and poke around a bit.

weiweishi commented 5 years ago

We will change the link to a page url opening in a new tab for "more" as a quick fix, and then if time permits, investigate on the modal solution.