ualbertalib / discovery

Discovery is the University of Alberta Libraries' catalogue interface, built using Blacklight
http://search.library.ualberta.ca
12 stars 3 forks source link

Proxy prefix not being prepended to some Electronic Access links. #2076

Closed ghost closed 4 years ago

ghost commented 4 years ago

Description:

A few records have been reported which should have the proxy prefix prepended to the electronic access links but do not. Other records are properly displaying the proxied URL. The same behaviour should apply to all electronic records (unless location is "Free Access", prepend the proxy prefix).

To Reproduce Steps to reproduce the behavior: These three records show the problem (hover over "University of Alberta Access") https://search.library.ualberta.ca/catalog/4114691 https://search.library.ualberta.ca/catalog/4114739 https://search.library.ualberta.ca/catalog/4113878

Expected behavior This record displays the right behaviour: https://search.library.ualberta.ca/catalog/6865591

Additional context Proxy logic is here. Record view logic is here.

NB: I'm not sure this is a code problem, since we've used the same proxy logic from the beginning, but I can't see a problem in the data. It would perhaps be worth digging into the data side of things (e.g. the MARC records).

theLinkResolver commented 4 years ago

All 3 of the examples have a blank second indicator for the 856. That must have something to do with it.

(It's a valid value in terms of what's permissible in that position, but I'm fairly certain it's a cataloguing error in these cases - the second indicator should be 0, I think. Please don't take that as gospel though.)

ghost commented 4 years ago

Thanks @theLinkResolver - I had noticed that, but I wasn't sure if that could be causing the problem. We don't look at it when determining the proxy logic. I can ask the cataloguers to make the change and then see if that fixes it.

ghost commented 4 years ago

Fairfax added the second indicator and that fixed the problem. No idea why!