search

ualbertalib / jupiter

Jupiter is a University of Alberta Libraries-based initiative to create a sustainable and extensible digital asset management system. This is phase 2 (Digitization).
https://era.library.ualberta.ca/
MIT License
23 stars 10 forks source link

Upgrade Bootstrap #3366

Open ConnorSheremeta opened 9 months ago

ConnorSheremeta commented 9 months ago

A bootstrap upgrade to at least 5.3.2 (currently on 4.6.2) is required to resolve this deprecation warning (https://blog.getbootstrap.com/2023/09/14/bootstrap-5-3-2/).

DEPRECATION WARNING: Passing percentage units to the global abs() function is deprecated.
In the future, this will emit a CSS abs() function to be resolved by the browser.
To preserve current behavior: math.abs(100%)
To emit a CSS abs() now: abs(#{100%})
More info: https://sass-lang.com/d/abs-percent

╷
│   $dividend: abs($dividend);
│              ^^^^^^^^^^^^^^
╵
node_modules/bootstrap/scss/vendor/_rfs.scss 54:14             divide()
node_modules/bootstrap/scss/mixins/_grid.scss 66:15            row-cols()
node_modules/bootstrap/scss/mixins/_grid-framework.scss 43:13  @content
node_modules/bootstrap/scss/mixins/_breakpoints.scss 65:5      media-breakpoint-up()
node_modules/bootstrap/scss/mixins/_grid-framework.scss 32:5   make-grid-columns()
#node_modules/bootstrap/scss/_grid.scss 72:3                    @import
bootstrap/scss/bootstrap.scss 16:9                             @import
app/assets/stylesheets/application.sass.scss 7:9               root stylesheet
ConnorSheremeta commented 1 month ago

I imagine that this upgrade will break some front-end components and will require following the upgrade guide followed by extensive testing.

From @jefferya on slack regarding a CVE which this upgrade (or an upgrade to 5.x.x) resolves: