search

ualbertalib / library-cms

Content Management System for the UofA Libraries website. Built on Comfy Mexican Sofa.
2 stars 0 forks source link

Bump Rails 7.2 #552

Open pgwillia opened 6 months ago

pgwillia commented 6 months ago

https://edgeguides.rubyonrails.org/7_2_release_notes.html

May be dependent on comfy.

murny commented 1 month ago

Looks like we can't do this until we migrate off of secrets

From https://edgeguides.rubyonrails.org/7_2_release_notes.html#railties-removals:

Remove deprecated Rails.application.secrets.

You can see this failing in the dependabot PR: https://github.com/ualbertalib/library-cms/actions/runs/10374144119/job/28720917903

I posted some ideas for doing this in the Jupiter Issue: https://github.com/ualbertalib/jupiter/issues/3347

Either we need to go to credentials which replaced secrets (but this requires coordination with Neil and changing how we do things for deployments) or basically create our own "secrets" config for the time being, like using a simple config_for. Or maybe explore some other options.