Closed jaronkk closed 9 years ago
Wow... thanks! We'll review soon.
I updated the pull request with a new change.
I modified login_cas.ctp to give information to the user if they sign in successfully through CAS but don't have access.
The "Request access" link is a mailto link to the email.send_all_feedback_to email address and populates the subject and body with helpful information, it looks like this:
I will go ahead an take a look at this.
I was able to get this to work locally using the UA WebAuth service (which uses CAS). I tested the following cases:
All these use cases worked as expected and the code seems to match best practices. Pending @michaelhagedon's approval, I will merge the pull request. Thanks for your work, @jaronkk!
It looks good to me. Thanks, @jaronkk and @simpsonw!
We use CAS for most of our authentication so I added CAS as a new authentication option.
Here are the files I added/modified
I based CasAuthenticate heavily off of the existing ShibbolethAuthenticate implementation.