search

ualibraries / Guide-on-the-Side

The University of Arizona Libraries will no longer provide support for Guide on the Side. The code will remain openly available; however, UAL can no longer provide code fixes or upgrades.
https://ualibraries.github.io/Guide-on-the-Side/about.html
Other
66 stars 48 forks source link

Fix src on graded question images #101

Closed jaronkk closed 8 years ago

jaronkk commented 9 years ago

This fixes #98

The changes here are on line 176 (parsing the images on graded content), and to the _parseImages function on line 213 (Adding the option to prepend the full url including protocol and host).

The whitespace changes are because my editor is configured to remove trailing whitespace and ensure there is a newline at the end of the file. If you want a cleaner commit I can update the pull request that doesn't make any whitespace changes.

michaelhagedon commented 9 years ago

@jaronkk Thanks! Normally, I think we’d prefer a separate commit for the whitespace, but the commit is pretty readable so I wouldn’t bother in this case. We’ll look through this soon.

simpsonw commented 8 years ago

@jaronkk Sorry, this one slipped through the cracks! I merged your changes locally and everything looked good. The issue with the src attribute was fixed and the regular functionality of the site was unimpeded. I will see about merging this into master once @michaelhagedon is back in the office.

michaelhagedon commented 8 years ago

This looks good to me. Thanks for the fix, @jaronkk!