search

ualibraries / Guide-on-the-Side

The University of Arizona Libraries will no longer provide support for Guide on the Side. The code will remain openly available; however, UAL can no longer provide code fixes or upgrades.
https://ualibraries.github.io/Guide-on-the-Side/about.html
Other
66 stars 48 forks source link

Feedback email fails for tutorials with no contact email #115

Open simpsonw opened 9 years ago

simpsonw commented 9 years ago

Steps to reproduce

  1. Create a tutorial and leave the "Contact Email" field blank.
  2. Visit the tutorial and go to the last page.
  3. Click the feedback link ("What did you think of this tutorial?")
  4. Fill out the form that pops up and click "Send feedback"

    Expected behavior

You will receive a message indicating the success or failure of the delivery of the feedback email.

Actual behavior

Nothing appears to happen.

Notes

This was discussed in #114. The issue seems to be that if the addBcc() function is passed an empty string, it causes an error, but since that call is outside of the try/catch block, the execution halts without a message being send back to the user.