search

ualibraries / Guide-on-the-Side

The University of Arizona Libraries will no longer provide support for Guide on the Side. The code will remain openly available; however, UAL can no longer provide code fixes or upgrades.
https://ualibraries.github.io/Guide-on-the-Side/about.html
Other
66 stars 48 forks source link

Scrolling broken in some instances #141

Closed simpsonw closed 8 years ago

simpsonw commented 8 years ago

In some (possibly all) cases, users are unable to scroll in the main tutorial iframe (see http://www.library.arizona.edu/applications/quickHelp/tutorial/searching-academic-search-complete). It's worth noting that at least in Chrome the scrollbar seems to appear for a brief moment while the page is loading and then disappear, so this might be a JavaScript issue.

simpsonw commented 8 years ago

A little more information: This was first reported when trying to embed EBSCO Academic Search Complete. I tried embedding a different site that also caused scrolling and it worked fine. It appears that EBSCO is setting overflow-y to hidden on the <body> tag when it's embedded. I tried to see if I could remove the property via JavaScript but it didn't work due to cross domain security issues. I'm not sure if there's anything we can do about this other than advise people to use pop up mode, but I will think it over a bit more.

simpsonw commented 8 years ago

It looks like this is something EBSCO is doing via JavaScript. In master.js, they're checking to see if window.top !== window.self, which is essentially checking to see if the set is embedded. If it is, they're setting g.pixelHeight = "sticky", which in turn is causing overflow-y to be set to hidden on the body. I don't think there's anything we can do about it other than use popup mode.

simpsonw commented 8 years ago

I am going to close this issue as it appears that there's nothing we can do about this on our end. As mentioned on the mailing list, it's possible to work around this issue by adding the following to your EBSCO branding:

<style>
body {overflow-y:visible !important;}
</style>

See https://groups.google.com/forum/#!topic/gots-discuss/-LObsuUwAoQ for more details.

simpsonw commented 8 years ago

FWIW, this appears to be working now, e.g.

http://www.library.arizona.edu/applications/quickHelp/tutorial/searching-academic-search-complete