Fixing notices/warnings for PHP 5.6

ualibraries / Guide-on-the-Side

The University of Arizona Libraries will no longer provide support for Guide on the Side. The code will remain openly available; however, UAL can no longer provide code fixes or upgrades.

https://ualibraries.github.io/Guide-on-the-Side/about.html

Other

66 stars 48 forks source link

Fixing notices/warnings for PHP 5.6 #172

Open BrendonKoz opened 6 years ago

BrendonKoz commented 6 years ago

I fixed any/all warnings and notices that I discovered running the current master under PHP 5.6 (with CakePHP debug set to 2).

This is just the start of the effort to properly upgrade compatibility to Cake PHP v2.8 (minimum) for PHP7 compatibility.

michaelhagedon commented 6 years ago

Thanks so much, @BrendonKoz! We'll take a look.

BrendonKoz commented 6 years ago

There are a lot of unnecessary text changes that have been made due to my editor (sorry). I just noticed that changes to app/Config/core.php was unfortunately not ignored like I thought it was -- Cake::Configure's debug value should not be changed to 2 for others. (Unrelated: Having issues with JavaScript-related processes in further upgrade path, thus the lack of additional progress.)