search

ualibraries / Guide-on-the-Side

The University of Arizona Libraries will no longer provide support for Guide on the Side. The code will remain openly available; however, UAL can no longer provide code fixes or upgrades.
https://ualibraries.github.io/Guide-on-the-Side/about.html
Other
66 stars 48 forks source link

Visited link color is confusing #92

Closed michaelhagedon closed 9 years ago

michaelhagedon commented 9 years ago

Students don't always realized visited links are still clickable.

simpsonw commented 9 years ago

I have pushed some changes in the branch gh_92_link_styles. I have removed the :visted style for the regular tutorial links so that they always appear clickable. Additionally, I believe there was also concern that the students did not think that the definition box links were clickable, so I have changed the bottom border to be solid rather than dotted to look more like a "regular" link.

simpsonw commented 9 years ago

You can see the new styles for the definition links and the regular links at http://webdev.library.arizona.edu/applications/quickHelp/tutorial/1-visited-link-colors-and-definition-boxes-test

liquid06 commented 9 years ago

Visited links before: visited-before Visited links after: visited-after

simpsonw commented 9 years ago

Any thoughts on the new look for the links, @lsult and @yvonnemery?

lsult commented 9 years ago

Hey I just took a look – one thing that got wonky for me was when I clicked the regular link and then went back, the underline disappeared? I think it would be better for it to stay? Also, is it good or not good practice now to have the color change once you’ve clicked? I actually have no idea, so I’m happy to defer to you guys on that one. I like the definition box link – we found that student didn’t understand to click something that was not blue and underlined, but blue and dots should work?

Thanks for the work on this – I’m super excited for the next release!

From: Will Simpson [mailto:notifications@github.com] Sent: Tuesday, February 17, 2015 4:01 PM To: ualibraries/Guide-on-the-Side Cc: Sult, Leslie A - (lsult) Subject: Re: [Guide-on-the-Side] Visited link color is confusing (#92)

Any thoughts on the new look for the links, @lsulthttps://github.com/lsult and @yvonnemeryhttps://github.com/yvonnemery?

— Reply to this email directly or view it on GitHubhttps://github.com/ualibraries/Guide-on-the-Side/issues/92#issuecomment-74774152.

simpsonw commented 9 years ago

I apologize, @lsult! I think I may have blown away the changes on the test server before you saw them, which may have caused some strange behavior. They should be back there now.

Regarding your question about the underline disappearing, this is kind of a quirk with how things are styled right now. The underline disappears when the link is considered active, so if you were to click elsewhere in the page, it would come back. Personally, I think it's kind of odd behavior, and I would vote for having the underline only disappear when you hover over a link.

The definition boxes links should look like regular links now, with solid underlines rather than dots.

lsult commented 9 years ago

Awesome – ok, I like the solid line and the darker color – I think the solid line makes it clear to click it for the definition box. I’m also with you on having the underline stay.

Thanks!

From: Will Simpson [mailto:notifications@github.com] Sent: Tuesday, February 17, 2015 4:30 PM To: ualibraries/Guide-on-the-Side Cc: Sult, Leslie A - (lsult) Subject: Re: [Guide-on-the-Side] Visited link color is confusing (#92)

I apologize, @lsulthttps://github.com/lsult! I think I may have blown away the changes on the test server before you saw them, which may have caused some strange behavior. They should be back there now.

Regarding your question about the underline disappearing, this is kind of a quirk with how things are styled right now. The underline disappears when the link is considered active, so if you were to click elsewhere in the page, it would come back. Personally, I think it's kind of odd behavior, and I would vote for having the underline only disappear when you hover over a link.

The definition boxes links should look like regular links now, with solid underlines rather than dots.

— Reply to this email directly or view it on GitHubhttps://github.com/ualibraries/Guide-on-the-Side/issues/92#issuecomment-74778506.

simpsonw commented 9 years ago

@lsult The underline should be staying now (you may have to to reload the page a couple of times to get the new styles). Regarding changing the color for visited links, we could do that (it's considered standard behavior in fact), but I believe there was concern about students not understanding that visited links were still clickable. Maybe picking a fairly standard color (like purple) for the visited links would work.

yvonnemery commented 9 years ago

Coming in a little late, but just the same feedback that Leslie had about the underline disappearing on the definition box. Another thing, will these be blue?

From: Will Simpson [mailto:notifications@github.com] Sent: Tuesday, February 17, 2015 4:01 PM To: ualibraries/Guide-on-the-Side Cc: Mery, Yvonne D - (ymery) Subject: Re: [Guide-on-the-Side] Visited link color is confusing (#92)

Any thoughts on the new look for the links, @lsulthttps://github.com/lsult and @yvonnemeryhttps://github.com/yvonnemery?

— Reply to this email directly or view it on GitHubhttps://github.com/ualibraries/Guide-on-the-Side/issues/92#issuecomment-74774152.

simpsonw commented 9 years ago

@yvonnemery, the underline disappearing should be fixed. Let me know if it still seems off.

Regarding the colors, the definition box links are currently this shade of blue/gray:

definition_link_color

The regular links are this color:

regular_link_color

And when you hover over the regular links they turn this color:

regular_link_hover_color

simpsonw commented 9 years ago

I have temporarily taken the changes off of webdev so we can see the changes from #91.

simpsonw commented 9 years ago

@lsult has mentioned that #90 is ready for deployment. What does everyone ( @michaelhagedon, @liquid06, @yvonnemery ) think of the colors for this task? I mention this because these two tasks are closely related and it would be hard to deploy one without the other,

simpsonw commented 9 years ago

Since issue #90 is considered ready for deployment, I am going to merge and deploy this task as well if I don't hear any objections from @yvonnemery or @lsult by the end of the day. Thanks everyone for your input!

simpsonw commented 9 years ago

Looks like the changes for this issue have already been merged into master. Closing this issue.