ualibraries / Guide-on-the-Side

The University of Arizona Libraries will no longer provide support for Guide on the Side. The code will remain openly available; however, UAL can no longer provide code fixes or upgrades.
https://ualibraries.github.io/Guide-on-the-Side/about.html
Other
66 stars 48 forks source link

Graded question images have incorrect src attribute #98

Closed jaronkk closed 8 years ago

jaronkk commented 9 years ago

There are two bugs here:

1) The graded test and quiz results don't call the _parseImages function to fix the src attribute on the img tags. 2) Emailed quiz results need a full url including the host for images to show up correctly.

I added a fix for both of those issues on our fork here: https://github.com/ndlib/Guide-on-the-Side/commit/d592ff1fee8cbebbeccbc4ed81be7ca509b658c5

Let me know if I should make a pull request.

I initially created a separate lib file for parsing the images because I thought I might have to call the function outside of the SteppableBehavior class, but that turned out to not be the case. I can move all of that functionality back into the _parseImages function if you would like.