uartois / sonar-golang

Sonarqube plugin for the golang language.
GNU Lesser General Public License v3.0
245 stars 32 forks source link

UnhandledErrors False Positives + Typo ? #40

Closed kedare closed 6 years ago

kedare commented 6 years ago

Description

False positive on UnhandledErrors, also it looks like there is a typo in the title of the error.

Steps to Reproduce

Create a code snippet that gets the returned error from a method Run analysis Check the errors on the web panel ( See screenshot )

screen shot 2017-10-19 at 11 10 01

Content of your sonar-project.properties

sonar.projectKey=haproxy-dynagent
sonar.projectName=HAproxy DynAgent
sonar.projectVersion=1.0
sonar.sources=./
sonar.exclusions=out/**,build/**

Versions

uname -a
Darwin mbp-mpoussin.local 17.0.0 Darwin Kernel Version 17.0.0: Thu Aug 24 21:48:19 PDT 2017; root:xnu-4570.1.46~2/RELEASE_X86_64 x86_64

sonar-scanner --version
INFO: SonarQube Scanner 3.0.3.778
INFO: Java 9 Oracle Corporation (64-bit)
INFO: Mac OS X 10.13 x86_64

Server: Version 6.5 (build 27846) 
Affecting both Golang Plugin 1.2.11-rc1 and 1.2.10

Additional Information

kedare commented 6 years ago

Nothing, my fault, I forgot to rerun the gometalinter before sonar-scanner (I forgot there was this manual step), so even if the code was update in SonarQube it was still reading the previous report.xml

Would not it be better to have it run automatically by sonar-scanner ?

thibaultfalque commented 6 years ago

Hi, Yes in theory it's possible. Please close this issue and create a new issue with this proposition of feature. Thanks.