uatisdeproblem / egm-app

EGM app
https://app.erasmusgeneration.org
Other
2 stars 1 forks source link

52 login esnaccounts #62

Closed rbento1096 closed 1 year ago

rbento1096 commented 1 year ago

closes #52

@uatisdeproblem can you give a check to the code to make sure everything is okay and also the points above? Not super urgent, just to make sure everything is ok

uatisdeproblem commented 1 year ago

Ok, prossima settimana guardo con calma

uatisdeproblem commented 1 year ago

For logging out, can we use the same, method for ESN and cognito?

Yes, but based on the type of login you have to make two different actions; therefore, I would add the type of user in the model's attributes

uatisdeproblem commented 1 year ago

we substitued 'configurations' in ESN-GA app for 'Roles' here. Does it make sense?

What kind of "roles" or "permissions" did you think of? Except for "administrator" and "standard user". So I can give you a more reasoned opinion.

rbento1096 commented 1 year ago

Yes, but based on the type of login you have to make two different actions; therefore, I would add the type of user in the model's attributes

Need to do this after fixing the login with Cognito

What kind of "roles" or "permissions" did you think of? Except for "administrator" and "standard user". So I can give you a more reasoned opinion.

As i said above I abandoned this logic. It is now an ENUM as is standard in IDEA. The full ENUM is here:

export enum Roles {
  NONE = 0, // starting user
  PARTICIPANT = 10, // user with an assigned spot
  DELEGATION_LEADER = 20, // same as participant, but can see delegation (in future)
  STAFF = 30, // will have some more permissions during the physical event
  OC = 40,  // these 3 might all be mixed into one, honestly, I added as a safekeep
  CT = 50,
  IB = 60,
  ADMIN = 70 // max permissions
}

Currently I'm only checking for ADMIN on certain actions because I still need Adel to confirm me which roles should do what.