Closed neculalaura closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
7298c37
) 88.18% compared to head (bc656ba
) 88.18%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@uditha-atukorala
rbac-policies_identities
table, should identity_id
or policy_id
come first)?src/events/concepts.h
@uditha-atukorala
- Do you say "Identity has policy" or "policy applies to identity"
- Do you want columns in the junction tables ordered alphabetically or same order as the table they reference in the table name (e.g. in the
rbac-policies_identities
table, shouldidentity_id
orpolicy_id
come first)?- Same applies for FK constraints?
- there is a lint issue in
src/events/concepts.h
policy_id
to come first.clang-format
it seems to style differently. I've left it what works for CI for the moment.
This issue changes the names of junction tables by swapping the referred tables and prefixing the names with the policy tables (e.g.
identities_rbac-policies
becomesrbac-policies_identities
)