GCP Label problem

[sbonaime]

With “2021/09/28_15:11:11.000" as a GCP Label, it is impossible to go to the GPC tagging window. When I click on the tag button, I return to the CVS import data

[coumbsek]

Reproduce easily after few tests. Seems to come from the fact that there are forward slash in the name.

Thus interpreation of page adresse for gcp does not works properly I think

For me we have 3 solutions :

• Do not allow certain characters in gcp name (not funny for user)
• Replace the "not-allowed" characters with jokers '_' for instance (but this can be weird for user too)
• Add an id for the GCP class and use this id to reference it, compare, access page and only use the name as a string for display. This is the most appealing and viable solution for me.

[coumbsek]

Few more tests and research another suggestion is use encodeURIComponent for gcpName. In \src\app\gcps-map\gcps-map.component.ts in becomes :

editImages(gcp: GCP) {
        this.ngZone.run(() => this.router.navigateByUrl('/images-tagger/' + encodeURIComponent(gcp.name))).then();
    }

I have replace it also in \src\app\gcps-map\gcps-map.component.ts but no idea if it is necessary.

I think this is the way to go. Everything seems to work now.

Could someone double check this ?

[pierotofy]

It looks correct, thanks for looking into this. Could you open a pull request for this @coumbsek :pray: ?