Add dtor to Feature to prevent destruction problems

uav4geo / OpenPointClass

Fast and memory efficient semantic segmentation of 3D point clouds. Runs on Windows, Mac and Linux.

GNU Affero General Public License v3.0

121 stars 17 forks source link

Add dtor to Feature to prevent destruction problems #10

Closed hobu closed 1 year ago

hobu commented 1 year ago

classifier.hpp:105:50: warning: delete called on 'Feature' that is abstract but has non-virtual destructor [-Wdelete-abstract-non-virtual-dtor]

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request}

hobu commented 1 year ago

This fixes #9

pierotofy commented 1 year ago

Thanks for the report and the proposed patch @hobu 🙏 I've since fixed this as part of #11