uazo / bromite-buildtools

my build machine for bromite development
GNU General Public License v3.0
333 stars 10 forks source link

Asking for a bottom tool bar πŸ™. #201

Open mridiot0 opened 1 year ago

mridiot0 commented 1 year ago

First of all, thanks to @uazo for bringing back this legendary browser πŸ™Œ. I like the browser, but I have 1 request to @uazo to add a bottom toolbar like the one that brave browser has. It's very inconvenient to use one-handedly for big phones so, it would be nice to have a bottom toolbar. There should be a toggle to enable the bottom toolbar for those who prefer full screen. It will be really amazing if you add the toolbar with atleast the home, tab group, and search (most important) in function. And thanks again for such an great effort πŸ‘ŒπŸ€—. Screenshot_20230514-123410_Brave - Beta

Kirshi912 commented 1 year ago

Accesibility β†’ toolbar to bottom?

mridiot0 commented 1 year ago

Hey πŸ‘‹, thanks for the response but I like the toolbar like brave browser has. It creates problem with my navigation key with the browser itself. For example when I turn the toolbar in bromite to bottom I cannot change the tabs by swiping to left of right it's just changes my apps. So it would be nice if it has dedicated bottom toolbar. And I like the features of changing tabs by swiping it helps in managing multiple tabs. I know that brave browsers bottom toolbar also allows to left to right tab switching but it doesn't cause the problem that is caused in bromite.

uazo commented 1 year ago

For example when I turn the toolbar in bromite to bottom I cannot change the tabs by swiping to left of right it's just changes my apps.

you mean this doesn't work? 1

mridiot0 commented 1 year ago

I mean, it works, but I have navigation gesture rather than soft keys, so if I swipe it, it changes the application itself, not the tab( it doesn't happen in brave toolbar, though). It will be more comfortable if there is another toolbar mostly dedicated to what I previously mentioned. Like the brave one with - search button, share button, tab switcher, and home button. If you are busy with other work then I'm not in a hurry you can take into consideration and add it to your task list. Thanks again πŸ˜‰.

marinoalfonz1 commented 1 year ago

Maybe add a simple pill shaped floating button in the bottom part (inspired by dynamic island maybeπŸ˜…) which can be used to switch tabs easily?

If interested i can fully elaborate the idea @uazo

mridiot0 commented 1 year ago

Dumb question but does it take too much effort or have to change numerous no of codeπŸ€” to make the toolbar like brave browser like I've showed previously. Screenshot_20230514-123337_Brave - Beta

DKB-91 commented 1 year ago

Considering I think that is something not present in any other Chromium alternatives (haven't tried Edge, but Vivaldi aside I'm sure no other chromium does have it), I'd say yes as that seems an added UI element added by Brave devs.

mridiot0 commented 1 year ago

Thanks for the info πŸ‘. I think maybe I just have to stick with it as long as there's no other option πŸ™„.

uazo commented 1 year ago

it doesn't happen in brave toolbar, though

I will check their code, maybe there is some android specific API to disable that behavior that I don't know.

Regarding the request, I don't think I will proceed. I prefer to invest the time in this idea

mridiot0 commented 1 year ago

Recently checked Opera browser they also has the similar bottom toolbar. May be this can help in research. Edit: It's ok if you don't consider this worth the time πŸ™ƒ maybe another time.

uazo commented 1 year ago

(only for me: link to https://github.com/uazo/bromite-buildtools/issues/227#issuecomment-1573484693)

If interested i can fully elaborate the idea

@marinoalfonz1 please, ideas are always welcome, but remember, no obligation to develop then.