Enable all Eyeo Adblock Plus features

marcinwiacek commented 1 year ago

"old" Bromite was able to block ads in m.youtube.com on video start, with builds here enabling blocking in "AdBlock settings" is not enough, you need to enable "Ad blocking" with ABP filters (I tried also with all lists enabled in settings menu below ABP filters).

Problem: after enabling these filters and entering video in m.youtube.com with ads on beginning user see black screen instead of video... and video plays after few seconds (something even, when you change page to other m.youtube.com subpage), but... after refreshing page ad is not displayed and video can be immediately started (it works like expected).

I could say, this is problem of "ABP filters", but... old Bromite + other browsers are working in this situation (blocking ads correctly).

Can be smth done here?

tried 110 and 111, Android 10

uazo commented 1 year ago

are you telling me that

with adblockplus enabled, the ad is not shown but a black block is shown while waiting for video
with adblockplus disabled, the ad is not shown and the video appears immediately

Try again, however, all things being equal, i.e. with the browser closed and reopened and new anonymous browsing window. let me know, if you can provide a video it's better

marcinwiacek commented 1 year ago

Hallo, I'm sorry for describing it maybe incorrectly, thank you for your answer. I'm looking for way for disabling ads in video in youtube. Bromite with ad-blocker was OK - I haven't seen ads for months, now (I returned to it yesterday) I see some of them. CHromium with old ad-blocker behaves the same -> doesn't block everything (it means, Chromium builds are not worse than Bromite) Chromium with new ad-blocker needs enabling "ABP filters" -> with them after opening video list & clicking on video video is opened with black screen (when we have ad on beginning) and video playback starts after few seconds, but... when you just refresh the page, everything is perfect (we don't have ad and playback starts immediately). For me it means, that "ABP filters" are maybe not enough, in the same time other browsers seems to work better (example: Vivaldi) -> it means, that maybe implementation of "new" adblocker with combination of other options is somehow problematic. It would be good, if this target (blocking all video ads) could be somehow achieved with any list combination or any other way, additionally it would be good to see lists descriptions in "new" adblocker like in other browsers. This "issue" is maybe not very important, but very welcome. Thank you & I hope, it's more clear. Sorry for misunderstanding.

uazo commented 1 year ago

I'm looking for way for disabling ads in video in youtube.

that adblock patch is still in work in progress. as far as i'm concerned i don't particularly care about blocking youtube video ads, but i know that adblock plus would be able to do it if i enabled anti-circumvention rules which are currently disabled in the code. I have already set myself the task of verifying the activation of that functionality, but it is not a priority. The issue is that in order to work it the adblock injects javascript code which I have not yet verified, and in fact I am disinclined to allow it. we will talk again

marcinwiacek commented 1 year ago

I know this project is not commercial + there are maybe much more interesting features, from the other hand - is it possible to do something here, please?

Full blocking functionalities help a lot in faster opening pages, allow for better watching youtube and help in many things.

uazo commented 1 year ago

(in v113)

I probably need to force the subscription update:

[20216:1240:0502/093303.940:INFO:subscription_validator_impl.cc(52)] [eyeo] Schema version
has changed, invalidating stored subscriptions.

is it possible to do something here, please?

@marcinwiacek certainly, it's in my activity queue.

uazo commented 1 year ago

see https://github.com/uazo/bromite-buildtools/issues/165#issuecomment-1534305276

zooool commented 1 year ago

Why is a commercial company's adblock being used instead of the free and open source uBlock?

uazo commented 1 year ago

From https://github.com/bromite/bromite/pull/2359#issuecomment-1264304853_

the code allows modification of the response headers clarify which ones and if only blocking is possible
the code allows the modification of the csp clarify which ones and if only blocking is possible
the code allows the url rewrite (but seems only to internal resources) however to be verified
understand if any error in "elemhide_for_selector.jst" not currently trapped with try / catch can arrive at the page as window.onerror
check if we are actually blocking the snippets, which being injected js code decided by external filters may not be suitable for bromite
understand why in the generation of the css string (in js emulation) the url is also injected.
the code predicts that localhost is never blocked but it is to check if the calls to localhost are already blocked by bromite
the code "installs" a proxy in the UrlLoaders, check the functionality better
there is some sort of metadata in the subscription file (https://eyeo.gitlab.io/adblockplus/abc/core-spec/#appendix-filter-list-syntax), understand what it is for
check better what the "sitekeys" and the "special filters" are
css injection seems to block the BackForwardCache
check converter.cc, if any rule is not suitable for bromite
check for redirect_info.bypass_redirect_checks

uazo commented 1 year ago

fixed in https://github.com/uazo/bromite/commit/5ffb665f31c33b5c5821f76309d4ff563ca4ee54 and in https://github.com/uazo/bromite/commit/a0874d05857203cb2a0eefd0519ea3393963c11f

uazo commented 1 year ago

in https://github.com/uazo/bromite/commit/af55aa0ddfc47fbaffafd60c385d4c43c7c5ad0c

removed support for header and csp filter option
removed support for json-override, simulate-event-poc, simulate-mouse-event snippets
allowed the use of override-property-read by eliminating the possibility of specifying a number as an argument (except 0 and 1)

trimechee commented 1 year ago

Hello Mr @uazo and Mr @marcinwiacek , thank you so much @uazo for this great awesome revolutionary marvelous web browser ! 💯 🥇

To avoid ads on youtube: here are some tips and suggestions including an important option that I hope our so beloved Cromite Browser will be able to integrate natively :

*use individual instances like https://piped.kavin.rocks/feed and https://piped.video/trending and many more instances available

*and here is a list of open source app for computer and smartphone to remove ads from youtube:

https://ironmaltese.github.io/YouTube-Frontend-Comparison/

I found another clever way to avoid ads on youtube and have smooth playback: disable MSE media source extension by going to about:config and setting the value "false" to "media.mediasource.enabled"

and therefore my request for the magnificent Mr @uazo: I read in the description of the magnificent Cromite Browser "Flags which have been retired from upstream Chromium but are still available in Bromite", so our dream because sometimes our internet connection becomes very weak when family members connect to wifi, so disabling Media Source Extension MSE allows to full buffer video streaming on youtube and other streaming sites like ok.ru/vido, subnet, uqload.....I tried disabling MSE media source extension in firefox and it works on several platforms and video players of this streaming site:

https://french-anime.com/animes-vf/1218-dead-mount-death-play.html

unfortunately MSE media source extension flag has been removed since chrome 51, in chrome 50, we were able to disable the media source extension MSE flag in chrome, we hope, and we know it is very difficult and complex and we are grateful to you for all these added improvements, our dream is that our beloved Cromite Browser will be able to add the removed MSE media source extension flag so we can full buffer video streaming and enjoy full HD video even with a very weak internet connection on many sites like youtube and uqload ...!

Starting with Chrome 51, they removed the disable-media-source in chrome://flags, before the disable-direct-write flag was in M52.

so our wish is to be able again to disable the Media Source Extensions in flags please ! Thank you so much :)

https://www.youtube.com/watch?v=XyVDmsfgXV8

I have other suggestion please : it looks like google might remove the google account of those who use an adblocker on youtube, so the solution seems to be "Duck Player," which shows (most) YouTube videos "without privacy-invading ads" and doesn't feed your recommendations"

duckduckgo is making a new web browser for windows and mac in beta version with a lot of privacy tools !

https://arstechnica.com/gadgets/2023/06/duckduckgo-offers-its-privacy-centered-browser-in-a-windows-open-beta/

uazo commented 1 year ago

I found another clever way to avoid ads on youtube

it's not a main goal of mine, although I'm convincing myself that ads = fingerprinting, but I'm thinking about it

.. and have smooth playback: disable MSE media source extension by going to about:config and setting the value "false" to "media.mediasource.enabled"

do you know what the MSE (media source extension) is? I don't think they had anything to do with "have smooth playback", rather the opposite. if you can find something (technical) to support your position we can talk about it, but for now it is not of my interest

EDIT: please write in https://github.com/uazo/cromite/issues/133#issuecomment-1656655398

buawf commented 1 month ago

@uazo

What filters are enabled by default in ABP ?

uazo commented 1 month ago

the code is to activate the lists according to the language set in the device. lists are defined in https://raw.githubusercontent.com/uazo/cromite/master/build/patches/eyeo-beta-118.0.5993.48-base.patch look for static std::vector<KnownSubscriptionInfo> recommendations = {

please note that that is the original code, and these are my modifications https://github.com/uazo/cromite/blob/master/build/patches/Eyeo-Adblock-for-Cromite.patch#L4986-L5022

uazo / bromite-buildtools

Enable all Eyeo Adblock Plus features #84