Disable Acceptable Ads in ABP by Default

Metrokoto commented 3 weeks ago

Preliminary checklist

[X] I have read the README
[X] I have searched existing issues for my feature request. This is a new issue (NOT a duplicate) and is not related to another issue.
[X] I have searched wont fix issues and this request is not among them
[X] This is a feature request for the Cromite browser; not the website nor F-Droid nor anything else.

Is your feature request related to privacy?

Yes

Is there a patch available for this feature somewhere?

Inside ABP's settings.

Describe the solution you would like

Adblock and Adblock Plus maintain a list of "Acceptable Ads" (I'm sure in most people's opinion, this is not acceptable for an adblocker to be doing)

AdGuard, uBlock Origin, among others, like Adblock Ultimate, have none of this.

I actually have proof this is enabled in Cromite; while browsing Reddit on Cromite, there are ads, and despite having plenty of custom filters that would definitely block them, they appear.

I would therefore like to request this "Acceptable Ads" feature of ABP to be disabled by default, and optionally behind a toggle.

Describe alternatives you have considered

Nothing else is possible, ABP's exceptions have full priority over any other filter rules.

uazo commented 3 weeks ago

Acceptable Ads are deactivated, I am surprised that people think otherwise. In my opinion, your problem is a different one; I suggest you check the lists you are using.

Metrokoto commented 3 weeks ago

Acceptable Ads are deactivated, I am surprised that people think otherwise. In my opinion, your problem is a different one; I suggest you check the lists you are using.

It is not my lists, I know for a fact EasyList blocks Reddit ads by default, as I tested it with ABP on Firefox. There are only ads when using ABP with Acceptable Ads turned on.

Screenshot_20240612-142126

If you look at the Acceptable Ads partner list by ABP, Reddit is one of them, just go to this URL and use "Find in Page" and search for "reddit.com"; https://easylist-downloads.adblockplus.org/exceptionrules.txt

uazo commented 3 weeks ago

the code that handles Acceptable Ads is removed. so your problem must be of a different nature. to find out what it is, you have to check the network log with developer tools

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale as there has been no recent activity in response to our request for more information. Please respond so that we can proceed with this issue.

Metrokoto commented 2 weeks ago

the code that handles Acceptable Ads is removed. so your problem must be of a different nature. to find out what it is, you have to check the network log with developer tools

Apologies but I cannot do this on mobile, and my desktop installation is having issues. However, as I mentioned, if you look at that list I sent you, you can clearly see Reddit's rules by searching reddit.com inside CTRL + F, I even tried inverting that list using grep to no avail. Most likely, on Android at least, the Acceptable Ads list is still enabled somehow.

uazo commented 1 week ago

the Acceptable Ads list is still enabled somehow.

is switched off: https://github.com/uazo/cromite/blob/b90d1c2cb7a9eaeee4052987aa7384a4748681fe/build/patches/Eyeo-Adblock-for-Cromite.patch#L4440-L4448

https://github.com/uazo/cromite/blob/b90d1c2cb7a9eaeee4052987aa7384a4748681fe/build/patches/Eyeo-Adblock-for-Cromite.patch#L4465-L4470

code is public

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale as there has been no recent activity in response to our request for more information. Please respond so that we can proceed with this issue.

github-actions[bot] commented 14 hours ago

This issue has been automatically closed as sufficient information hasn't been provided on the issue for further actions to be taken. Feel free to add more information.

uazo / cromite