uazo / cromite

Cromite a Bromite fork with ad blocking and privacy enhancements; take back your browser!
https://www.cromite.org/
GNU General Public License v3.0
2.88k stars 61 forks source link

Can't change Cromite's language #1257

Open theFireProject opened 3 days ago

theFireProject commented 3 days ago

Preliminary checklist

Details
Cromite version 126.0.6478.127
Device architecture arm64-v8a
Platform version Android 13
Android Device model Samsung Galaxy S20+ (SM-G986U1)
Is the device rooted? No
Changed flags No flags changed
Is this bug happening in an incognito tab? No
Is this bug caused by the adblocker? No
Is this bug a crash? No
Can the bug be reproduced with corresponding Chromium version? No (tested with Chrome version 126.0.6478.122)
Are you sure? Yes

Describe the bug

I can't change Cromite's language. It's set to Current device language by default and it's impossible to change to a different language.

Steps to reproduce the bug

My phone's language is set to German.

  1. Go to Settings > Languages
  2. Under Cromite's language select English (United States)
  3. Press Restart Cromite

Expected behavior

Chromite's language should be set to English now. When I go to Settings > Languages, the selected language under Cromite's language should be English.

Actual behavior

Chromite's language is still set to German after the restart. When I go to Settings > Languages, German is still selected under Cromite's language.

Additional info

This bug doesn't exist in Chrome, only in Cromite (and Bromite).

It seems like Cromite's language settings are outdated. They look exactly as in Chrome but Cromite doesn't support changing the app's language via the App info page in the phone's settings. (see screenshots)

It would be nice if this was fixed and Cromite was brought up to par with Chrome, so you can also see an option for Cromite's langauge on the App info page.

Screenshots

Chrome Cromite

Recording

https://github.com/uazo/cromite/assets/61639215/36b27450-c127-4410-a4e0-76bc14388468

uazo commented 2 days ago

I don't see any problems, the ui adjusts correctly if you use the setting directly in the settings of cromite. try sending a video.

theFireProject commented 2 days ago

I have attached a video. You can see that I'm trying to change to a different language, but it doesn't work.

I have changed my device's language to English, so the UI is in English by default. In Cromite the language is set to Current device language. I'm trying to change from Current device language to German but it's not possible to change the language.

theFireProject commented 2 days ago

I noticed that I have the same problem in Brave. There's some problem with Brave, Bromite and Cromite that makes it impossible to change the app's language. But there's no problem in Chrome.

The difference between Chrome and the other browsers is that Chrome supports Android's settings for individual app languages. It allows you to change the app's language in Android's settings (as described here Change app language on your Android phone - Android Help) and not only in the app's internal settings. You can also see that in my screenshots above.

Why is this feature missing in Cromite? Cromite is based on Chrome, so was it removed intentionally?

uazo commented 2 days ago

so was it removed intentionally?

No. well, then let's add that the anomaly of anomalies is that it works for me! :) maybe it is something related to A13. i will try browserstack.

theFireProject commented 2 days ago

What phone do you use? Maybe it could also be related to Samsung phones?

uazo commented 1 hour ago

What phone do you use?

I tried it in the android emulator.