unnecessary Ads space in website

[abdarker]

Preliminary checklist

• [X] I have read the README.
• [X] I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
• [X] I have updated Cromite to the latest version. The bug is reproducible on this latest version.
• [X] This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else.

Can the bug be reproduced with corresponding Chromium version?

Yes

Are you sure?

Yes

Cromite version

128.0.6613.40

Device architecture

arm64-v8a

Platform version

Android 14

Android Device model

Redmi Turbo 3

Is the device rooted?

No

Changed flags

'no flags changed'

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

Yes

Is this bug a crash?

no.

Describe the bug

Details

 unnecessary space in https://apkmirror.com

Steps to reproduce the bug

go to https://apkmirror.com

Expected behavior

there shouldn't be any space

Details


Screenshots

No response

[Xisrr1]

Use the built-in EasyList filter.

[abdarker]

Use the built-in EasyList filter.

i tried everything in cromite putting ublock's filters Adguard's filters it works in brave. i tried literally everything. AdBlock plus is the MAIN culprit. it prevents ublock's css injection that's why it leaves annoying big space.

[uazo]

the problem is the list you use is not specific to cromite.

[abdarker]

the problem is the list you use is not specific to cromite.

so then we gotta live with this big ads space? then even tho i like cromite i got no choice but to stick to brave sadly

[uazo]

so then we gotta live with this big ads space?

you just have to wait for the lists to update their rules, perhaps you could communicate this to the maintainers

[abdarker]

thank you

[uazo]

there is one thing I do not understand, maybe @Retold3202 can make me understand it.

https://github.com/easylist/easylist/blame/b168cbf3519d3fbcc5fb383a64a172fd82bb87fe/easylist/easylist_allowlist_general_hide.txt#L296

for apkmirror, in easylist, there is an exception to hide for ins.adsbygoogle[data-ad-slot] and .adslot, why do you think? Looking at the blame does not understand the reason for the inclusion.

in doubt of my bug, I tried brave with the same lists, same behaviour.

using ublock instead, no problem. makes me doubt that the biggest difference between ublock and adblock is the quality of the lists #1245 #560 i wonder if it makes sense to think about using ublock lists with adblockplus, adapting them with some script.

[uazo]

enough with these comments!

[celenityy]

there is one thing I do not understand, maybe @Retold3202 can make me understand it.

https://github.com/easylist/easylist/blame/b168cbf3519d3fbcc5fb383a64a172fd82bb87fe/easylist/easylist_allowlist_general_hide.txt#L296

for apkmirror, in easylist, there is an exception to hide for ins.adsbygoogle[data-ad-slot] and .adslot, why do you think? Looking at the blame does not understand the reason for the inclusion.

Looks like it's for Anti-Adblock to avoid detection.

in doubt of my bug, I tried brave with the same lists, same behaviour.

How did you test it? Brave already includes EasyList by default (+ other lists like EasyPrivacy) with their own tweaks, so maybe adding those lists separately on top of Brave's defaults is causing the problem for Brave. You could also enable Brave's 'Aggressive' content blocking to rule that out. I myself just tested apkmirror.com on Brave for iOS with 'Aggressive' blocking enabled and can confirm I don't see the blank space.

using ublock instead, no problem. makes me doubt that the biggest difference between ublock and adblock is the quality of the lists https://github.com/uazo/cromite/issues/1245 https://github.com/uazo/cromite/issues/560

I'm not sure - uBlock Origin, Brave, & Cromite in this case are all (to my understanding) using the same EasyList filter. Unless some of the other default lists uBlock Origin & Brave use that Cromite doesn't are interfering and removing the white space, my guess would be that this is some kind of limitation or incompatibility with ABP's filtering engine. It might just not be as effective for cosmetic filtering like this. Probably needs more testing.

i wonder if it makes sense to think about using ublock lists with adblockplus, adapting them with some script.

This is probably worth pursuing - since uBlock Origin's default lists are of very high quality (Also used by Brave & many other content blockers by default). We would need to investigate the specific differences between uBo's syntax & ABP's syntax, and what we would have to remove or adapt to get the lists working as expected. I know that they're pretty similar so I don't think something like this would be too difficult, but we would need to look and see.

[uazo]

Looks like it's for Anti-Adblock to avoid detection.

could be, but deleting the rule does not seem to have an active anti-adblock in apkmirror

How did you test it?

why do you ask? simply by selecting the list.

Details

 

'Aggressive' blocking enabled and can confirm I don't see the blank space.

I hadn't tried it, who knows what changes. I confirm that with that option I do not see the space, I will try to find out why.

uBlock Origin, Brave, & Cromite in this case are all (to my understanding) using the same EasyList filter.

no, it doesn't, ublock has its own filters that seem to work better.

my guess would be that this is some kind of limitation or incompatibility with ABP's filtering engine.

I too thought it was a bug, but I checked, by writing in the log the css that is injected into the page (directly from code), simply the #@# rule takes precedence over ## so it is correct that it is not included in the css.

We would need to investigate the specific differences between uBo's syntax & ABP's syntax

i looked at uBo code a bit and compared it with adblockplus's, there are things that adblockplus doesn't have and things that don't work well, but i have to rule out my bugs first.

unfortunately this is a bit long because:

• cromite does not have the latest version of adblock plus to solve this I would have to spend at least a week because my changes are quite intrusive, I would have to talk to eyeo to ask if it is possible to bring them upstream
• I should integrate the patch into the vanilla version of chromium (which I am currently preparing) by deactivating it by default so that I can understand whether the problem is mine or their limitation. e.g. in reference to #1406, I understand what the problem is, but I do not know whether it is my fault or not.

As we move forward, the time to devote to each individual issue becomes greater... this is becoming a big problem.

[abdarker]

when i add this list to brave that weird ads space is completely gone. even the "these's an ads here" text is completely gone as well. but when i remove it leaves weird text in there. https://ublockorigin.pages.dev/filters/filters.min.txt

ref: https://ublockorigin.pages.dev/

it's clean

Details


without that filter

Details