uazo / cromite

Cromite a Bromite fork with ad blocking and privacy enhancements; take back your browser!
https://www.cromite.org/
GNU General Public License v3.0
3.57k stars 85 forks source link

Mouse Tooltip Translator Dont Work Hotkey #1435

Open leakmx opened 2 months ago

leakmx commented 2 months ago

Preliminary checklist

Can the bug be reproduced with corresponding Chromium version?

No

Are you sure?

No

Cromite version

128.0.6613.116

Device architecture

windows

Platform version

Windows 11

Android Device model

x64

Is the device rooted?

No

Changed flags

no flags changed

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

No

Describe the bug

https://github.com/ttop32/MouseTooltipTranslator/

This extension has bindings via ctrl shift alt. But they don't work in cromite. Mouse binds work. In other chromium browsers everything works fine. Checked on ungoogled.

Steps to reproduce the bug

  1. Downloaded cromite through chrlauncher
  2. Downloaded the extension
  3. I open any site, select a word and press the bind for TTS (default left ctrl). Any action when bind to ctrl alt shift in this extension does not work.
  4. Nothing happens.

Expected behavior

I expect the extension to work normally as in other chromium browsers

Screenshots

No response

uazo commented 2 months ago

I don't think the problem is related to ctrl, but rather to tts which is disabled in cromite.

leakmx commented 2 months ago

I don't think the problem is related to ctrl, but rather to tts which is disabled in cromite.

But if I enable voicing without bind or mouse bind in the settings(Settings - Main - Voice When - Always/Select/Click Middle/Click Left/Click Right ). It works.

Other non tts options don't work on alt/shift/ctrl binds either. For example settings - advanced - translate writing when. Or settings - advanced - OCR when

leakmx commented 2 months ago

Were you able to reproduce the problem? Any ideas for a solution?

uazo commented 2 months ago

Were you able to reproduce the problem?

Yes.

Any ideas for a solution?

no, not yet. I think the incompatibility is introduced by the keyboard protection patch. I have seen the extension code, but it is not immediately readable. Too bad, it will have to be debugged.