uazo / cromite

Cromite a Bromite fork with ad blocking and privacy enhancements; take back your browser!
https://www.cromite.org/
GNU General Public License v3.0
3.25k stars 73 forks source link

Crashes when clicking permissions button on address bar on some sites #1438

Open Metrokoto opened 1 week ago

Metrokoto commented 1 week ago

Preliminary checklist

Can the bug be reproduced with corresponding Chromium version?

No

Are you sure?

No

Cromite version

Version 128.0.6613.116 (Official Build) (64-bit)

Device architecture

windows

Platform version

Windows 10

Android Device model

Not android

Is the device rooted?

No

Changed flags

none

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

Crashes when trying to generate a report and clicking save does nothing, can't do this

Describe the bug

Clicking the permissions icon on the address bar causes a crash to occur and on some sites it doesn't

Steps to reproduce the bug

Just go on different sites and try clicking on the permissions icon, sometimes they will crash and sometimes they won't, I can't try it now as I will lose the bug report progress yet again, but just trust me when I say that sites I frequent often don't seem to do it but new ones do, no clue why.

Expected behavior

Permissions menu opens up

Screenshots

No response

Metrokoto commented 1 week ago

Clicking the permissions icon on the address bar causes a crash to occur and on some sites it doesn't

Example: For me github.com doesn't have the issue but nytimes.com does

Metrokoto commented 1 week ago

This was an issue I noticed back in 127 and then forgot about it, I stayed on version 126 for a long time hoping it was fixed but here we go again.

Metrokoto commented 1 week ago

On sites that don't crash instantly when I press the permissions icon, if I click reset permissions, it does crash.

Metrokoto commented 1 week ago

@uazo Any chance of a rapid fix? This is making Cromite almost unusable.

uazo commented 1 week ago

I do not detect any problem. is it possible to receive the crash log (\User Data\Crashpad\reports)?

Metrokoto commented 1 week ago

I do not detect any problem. is it possible to receive the crash log (\User Data\Crashpad\reports)?

Well it is crashing for me so there clearly is a problem... and no, the folder is empty.

Metrokoto commented 1 week ago

@uazo

Ignore my last message, I managed to get it to spit one out by using the Crashpad launch args to output it to a custom directory path.

[link removed]

jookk commented 1 week ago

On android (Cromite 128.0.6613.120) , it's impossible to change site permissions too. They are empty Screenshot_20240907_070316

uazo commented 1 week ago

call stack:

chrome.dll!logging::LogMessage::BuildCrashString(void)
chrome.dll!logging::LogMessage::Flush(void)
chrome.dll!logging::LogMessage::~LogMessage(void)
chrome.dll!??_GNotReachedLogMessage@?A0xAE67E2E6@logging@@UEAAPEAXI@Z.c6b7d8f4dab3eeff6a22e22bba2a81c7()
chrome.dll!logging::CheckError::~CheckError(void)
chrome.dll!PageInfoUI::PermissionStateToUIString(class PageInfoUiDelegate *,struct PageInfo::PermissionInfo const &)
chrome.dll!PageInfoUI::PermissionMainPageStateToUIString(class PageInfoUiDelegate *,struct PageInfo::PermissionInfo const &)
chrome.dll!PermissionToggleRowView::UpdateUiOnPermissionChanged(void)
chrome.dll!PermissionToggleRowView::PermissionToggleRowView(class ChromePageInfoUiDelegate *,class PageInfoNavigationHandler *,struct PageInfo::PermissionInfo const &,bool)
chrome.dll!PageInfoMainView::SetPermissionInfo(class std::__Cr::vector<struct PageInfo::PermissionInfo,class std::__Cr::allocator<struct PageInfo::PermissionInfo> > const &,class std::__Cr::vector<class std::__Cr::unique_ptr<struct PageInfoUI::ChosenObjectInfo,struct std::__Cr::default_delete<struct PageInfoUI::ChosenObjectInfo> >,class std::__Cr::allocator<class std::__Cr::unique_ptr<struct PageInfoUI::ChosenObjectInfo,struct std::__Cr::default_delete<struct PageInfoUI::ChosenObjectInfo> > > >)
chrome.dll!PageInfo::PresentSitePermissions(void)
chrome.dll!PageInfo::InitializeUiState(class PageInfoUI *,class base::OnceCallback<void >)
chrome.dll!PageInfoMainView::PageInfoMainView(class PageInfo *,class ChromePageInfoUiDelegate *,class PageInfoNavigationHandler *,class PageInfoHistoryController *,class base::OnceCallback<void >)
chrome.dll!PageInfoViewFactory::CreateMainPageView(class base::OnceCallback<void >)
chrome.dll!InternalPageInfoBubbleView::GetClassMetaData(void)
chrome.dll!PageInfoBubbleView::CreatePageInfoBubble(class views::View *,class gfx::Rect const &,class aura::Window *,class content::WebContents *,class GURL const &,class base::OnceCallback<void >,class base::OnceCallback<void >)
chrome.dll!LocationBarView::ShowPageInfoDialog(void)
chrome.dll!views::ButtonController::OnMouseReleased(class ui::MouseEvent const &)