uazo / cromite

Cromite a Bromite fork with ad blocking and privacy enhancements; take back your browser!
https://www.cromite.org/
GNU General Public License v3.0
3.61k stars 87 forks source link

A small bug in adblock switch #151

Closed eisklwksjs closed 1 year ago

eisklwksjs commented 1 year ago

Preliminary checklist

Can the bug be reproduced with corresponding Chromium version?

Yes

Cromite version

579013604

Device architecture

arm64-v8a

Android version

13

Device model

poco x3 NFC

Changed flags

no flags changed

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

Yes

Is this bug a crash?

No

Describe the bug

It's a minor bug related to turning the adblocker on / off; Even thought we add our custom filterlists to the adblock plus filters and if we don't turn first adblocker switch (the one that hosts bromite filters) on, adblocking doesn't take effect......

checked it with https://d3ward.github.io/toolz/adblock.html

Steps to reproduce the bug

  1. Add your favourite custom filters to adblock plus filter lists
  2. Check adblock performance by visiting tool created by d3ward
  3. turn off the first adblock switch (the one that hosts bromite filters in .dat format)
  4. Check adblock performance again

Expected behavior

The state of First adblock switch should not effect adblovking as it is deprecated.

Screenshots

No response

uazo commented 1 year ago

related https://github.com/uazo/cromite/issues/104