Add confirmation to exit if closing an incognito tab closes the browser with other incognito tabs open

BugReportI commented 4 weeks ago

Preliminary checklist

[X] I have read the README
[X] I have searched existing issues for my feature request. This is a new issue (NOT a duplicate) and is not related to another issue.
[X] I have searched wont fix issues and this request is not among them
[X] This is a feature request for the Cromite browser; not the website nor F-Droid nor anything else.

Is your feature request related to privacy?

No

Is there a patch available for this feature somewhere?

Not sure.

Describe the solution you would like

Closing a tab by back button/gesture should not close all tabs in incognito.

Also make this option work if the above is done through normal tabs so if user does not want the incognito tabs to be closed they will not be closed unless user explicitly closes them but does want to close a specific tab.

Describe alternatives you have considered

I do not think there is one.

uazo commented 4 weeks ago

Also make this option work if the above is done through normal tabs so if user does not want the incognito tabs to be closed they will not be closed unless user explicitly closes them but does want to close a specific tab.

No, closing all incognito windows also deletes the profile and thus the deletion of all data. Allows the user to reopen a new, clean incognito session.

BugReportI commented 4 weeks ago

Also make this option work if the above is done through normal tabs so if user does not want the incognito tabs to be closed they will not be closed unless user explicitly closes them but does want to close a specific tab.

No, closing all incognito windows also deletes the profile and thus the deletion of all data. Allows the user to reopen a new, clean incognito session.

I know closing all tabs should do that.

I mean when you try to close one tab clicking back button or gestures then it should not close all the other incognito tabs.

This only happens if you cannot navigate any further back on the tab that you are navigating from and this closes Cromite or just the Cromite window if you have multiple windows of Cromite open.

I do not think anyone wants all the other incognito tabs to be closed just because they use back button/gestures(not swipe to close tab) to close just one tab.

You can try this by opening multiple incognito tabs and closing one of them by pressing the back button or gestures(not swipe to close tab) and it will close all incognito tabs not just that one incognito tab you want to close. The same thing happens when trying to close normal tab it should not close the all incognito tabs if the user only wants to close one tab like this.

I cannot record a video of this because it is in incognito and changing the flag to allow does not allow to record so I cannot provide video showing this.

BugReportI commented 4 weeks ago

I cannot record a video of this because it is in incognito and changing the flag to allow does not allow to record so I cannot provide video showing this.

If this is as I think related to Android and you have Root+Magisk/XPosed/LSposed, then there are Modules which can bypass Flag_Secure and allow you to make a screenshot / record a video no matter what (in theory, I don't have any of the above). I hope this is helpful to the OP.

Is there a specific one?

I tried one and it does allow to take screenshots and record video but it does not close any of the incognito tabs by doing the actions mentioned in my previous post.

So I do not know how to proceed if the only way to record is to disable secure flag but doing so also does not close the incognito tabs.

BugReportI commented 3 weeks ago

I tried some other Magisk modules and they seem to behave the same way as the initial one I tried.

I think it would be good to treat the other incognito tabs as the same way normal tabs are treated when you are just trying to only close one tab regardless of if it is incognito tab or not. If adding a confirm is no good.

BugReportI commented 3 weeks ago

I tried out Bromite in incognito and it does not seem to close all incognito tabs if I press back button to close one tab and it closes Bromite.

The Bromite version is 108.0.5359.156.

Edited to add: Could the way Bromite handles incognito tabs in these situations be used in Cromite?

BugReportI commented 3 weeks ago

It seems I misunderstood how Bromite handles the closing tabs in incognito, it seems to close the browser but not the tab if you press back button.

So it would not help if user just wants to close one tab this way in Cromite.

BugReportI commented 2 weeks ago

It seems to behaves differently in Cromite 130.0.6723.117.

Now it does not close the other incognito tabs or does not close the single incognito/normal tab through back button/gesture if the flags Redact sensitive content during screen sharing, screen recording, and similar actions is disabled and Incognito Screenshot is enabled.

In both situations the incognito tabs are kept.

Edited to add: Correct flags.

BugReportI commented 5 days ago

In this video it shows all incognito tabs when just trying close one by back button with three button navigation bar.

https://github.com/user-attachments/assets/c6553ece-c373-4c23-b664-d2d7a702edea

It should do the same thing if you try close a normal tab and closes all incognito tabs back button on navigation bar, I cannot record video this because it behaves differently with flags to record in incognito enabled.

Also the back gestures will close all incognito tabs as well if trying a incognito or regular tab. Same reason as above why I cannot show video of this.

uazo / cromite