Dns CNAME support in Adblock Plus

[Embassy4016]

Preliminary checklist

• [X] I have read the README
• [X] I have read the FAQs.
• [X] I have searched existing issues for my feature request. This is a new issue (NOT a duplicate) and is not related to another issue.
• [x] This is a feature request for the Cromite browser; not the website nor F-Droid nor anything else.

Is your feature request related to privacy?

No

Is there a patch available for this feature somewhere?

Not that I am aware of. But brave browser is pretty effective at doing this.

Describe the solution you would like

Cromite fail at blocking cosmetic elements, both static and dynamic ads. I am not talking about blank space in the webpage but rather page redirects in certain websites. Brave manages to block these redirects. Don't have the technical knowledge to actually understand or give solution to the problem but you can check at d3ward

Describe alternatives you have considered

Integrate cosmetic filtering from brave browser, adblock plus or ublock origin

[github59173]

This is a very important issue to fix. Ublock origin is the gold standard and should be followed as closely as possible to resolve this issue.

[uazo]

Cromite fail at blocking cosmetic elements

cosmetic filter rules (i.e. css injection) is already a supported feature.

Integrate cosmetic filtering from brave browser, adblock plus or ublock origin

this browser already integrates adblock plus

but rather page redirects in certain websites.

with reference to adblock, I don't know what you are referring to.

[Embassy4016]

This is screenshot from cromite browser

Details


And this one is from brave browser

Details


Unlike brave browser, Cromite browser is unable to block embedded ads Link to the site- https://solidtorrents.to/torrents/the-shawshank-redemption-1994-720p-avc-rus-leonard-6c661/5bcb41427da3981cefcc26b6/

[uazo]

the problem here is the lack of support for CNAME in AdBlock Plus. It needs some work to add it. Thank you for the report and especially for the example.

Issue 1317943: HTTP/3 protocol upgrade for HTTPS DNS records perhaps useful to understand how to extract new information from the dns.

[jakariyaa]

Not very sure if it's related to this issue as well, but the anti adblock killer function doesn't work as intended. (I do have adblock and anti circumvention and snippets feature enabled)

With Cromite:

Details


With Brave:

Details


My ad blocking settings in Cromite:

Details


Example website: https://ottprime.store/

[Embassy4016]

Glad I could clarify the issue. The website I mentioned respects user choice when they decide to close the ads. Some websites just redirect the user to other spam/phishing sites irrespective of where the user clicks in the webpage. Hope you find a way to solve this issue. Thanks for all the work you are doing.

[larena1]

I just switched from Brave to Cromite and am also seeing ads now similar to those that @Embassy4016 posted but on other sites. These don't show in Brave or Firefox with uBlock Origin.

Can you rip out AdBlock Plus for uBlock Origin? It's way more popular and better maintained also.

[larena1]

Seems it's not the actual AdBlock Plus addon but an implementation in C++ embedded in the Chrome code. Are you sure you can fix that in a way that really works? Because right now it's missing way too many ads compared to uBlock and also the regular AdBlock Plus addon.

[uazo]

but an implementation in C++ embedded in the Chrome code

correct, the implementation is the official eyeo implementation.

Are you sure you can fix that in a way that really works?

I can give it a try.

[uazo]

Because right now it's missing way too many ads compared to uBlock and also the regular AdBlock Plus addon.

I would like someone to open a task with examples and how to reproduce the differences.

[larena1]

Because right now it's missing way too many ads compared to uBlock and also the regular AdBlock Plus addon.

I would like someone to open a task with examples and how to reproduce the differences.

There are actually so many examples of what the current implementation won't catch

https://www.independent.co.uk/news/uk/gaza-daily-mirror-israel-natwest-hamas-b2437449.html https://www.huffpost.com/entry/geert-wilders-netherlands-election-win_n_655e6a37e4b0c91d8279840e

And lots more that can be added to the task

[uazo]

@larena1 thanks, but I do not see any ads in the links you have indicated.

[larena1]

@larena1 thanks, but I do not see any ads in the links you have indicated.

Which lists do you have enabled and do you have any DNS based AdBlocker like PiHole or AdGuard in your home network?

[uazo]

Which lists do you have enabled

everything by default:

Details


do you have any DNS based AdBlocker like PiHole or AdGuard in your home network?

No

[uazo]

If I deactivate adblock I see a banner at the bottom:

Details


[larena1]

Can you try refreshing the page while you're on it and see if that changes anything? And there's actually a whole lot more of ads on that page than just the thing at the bottom.

[uazo]

https://github.com/uazo/cromite/assets/29201891/5edcd757-f949-4cd5-9cb5-658aca831b61

[larena1]

Did you try refreshing the page either from the menu or pull to refresh?

[larena1]

https://github.com/uazo/cromite/assets/60823161/2f044cd7-5aa9-4265-9f6d-f13d0aa898f3

The bottom area will be empty first but when I refresh the page, it'll show all ads.

[uazo]

please check that the legacy adblock is active. unfortunately, that flag is unique for now and deactivation also includes deactivation of adblock plus.

[larena1]

I disabled legacy AdBlock as it'd trigger the AdBlock detection on one of the sites I frequently visit. But when you say that also disabled the new AdBlock, then it might've also been that what triggered the detection?

Do you think it'd be easier to just use uBlock as an addon instead of the current implementation?

[uazo]

I disabled legacy AdBlock as it'd trigger the AdBlock detection on one of the sites I frequently visit But when you say that also disabled the new AdBlock, then it might've also been that what triggered the detection?

tracked by https://github.com/uazo/cromite/issues/251

Do you think it'd be easier to just use uBlock as an addon instead of the current implementation?

easy, no, it's not. it's simpler that eyeo develops its adblock for chromium and i use it. then whether it can be improved is another matter.

[uazo]

Issue 1151047: Expose DNS record CNAME aliases to the SubresourceFilter

[larena1]

easy, no, it's not. it's simpler that eyeo develops its adblock for chromium and i use it. then whether it can be improved is another matter.

I just thought it might be possible because Kiwi uses the addon interface and Brave also (maybe even for AdBlock but I didn't check). And Vivaldi's built-in AdBlock also blocks ads just fine. Maybe you can look into the latter two's implementation?