uazo / cromite

Cromite a Bromite fork with ad blocking and privacy enhancements; take back your browser!
https://www.cromite.org/
GNU General Public License v3.0
3.47k stars 78 forks source link

Not clearing history/most visited sites on startup #313

Closed Embassy4016 closed 1 year ago

Embassy4016 commented 1 year ago

Preliminary checklist

Can the bug be reproduced with corresponding Chromium version?

Yes

Cromite version

Cromite 117.0.5938.63

Device architecture

arm64

Platform version

Android 13

Android Device model

Pixel 7

Is the device rooted?

No

Changed flags

Strict origin isolation, smooth scrolling, parallel downloading, back forward cache

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

No

Describe the bug

When delete all history on startup is enabled, the browser sometimes does not clear the most visited sites or does not clear history. You have to restart the browser twice to clear the history/most visited sites. The bug is not present always but happens sometimes, so reproducing it twice is very difficult. But it has happened a couple of times in this version and also in the previous versions. I have been trying to reproduce it but it happens at random so I am unable to take logs. I'll upload logs or screenshot when it happens again.

Steps to reproduce the bug

Enable clear history on startup-> Open a bunch of sites in different tabs-> Exit the browser-> Open the browser again

Expected behavior

No history or most visited sites should be visible on startup.

Screenshots

No response

uazo commented 1 year ago

Device architecture

arm

arm64, right?

When delete all history on startup is enabled, the browser sometimes does not clear the most visited sites or does not clear history

but remove the incognito pages?

Embassy4016 commented 1 year ago

Don't use incognito mode at all or its features. I experienced this bug in regular mode with clear all history on startup. Yeah arm64

uazo commented 1 year ago

Is this bug happening in an incognito tab?

Yes

how about this one?

I experienced this bug in regular mode with clear all history on startup

I will check, bit unfortunately I never delete the history so it has never happened to me. alternatively, you can disable it at all (there is an option :)

if you can figure out how to reproduce the bug, reopen the task

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale as there has been no recent activity in response to our request for more information. Please respond so that we can proceed with this issue.

github-actions[bot] commented 1 year ago

This issue has been automatically closed as sufficient information hasn't been provided on the issue for further actions to be taken. Feel free to add more information.