uazo / cromite

Cromite a Bromite fork with ad blocking and privacy enhancements; take back your browser!
https://www.cromite.org/
GNU General Public License v3.0
3.55k stars 84 forks source link

Add flag to reenable getGamepads #326

Open wetterskan opened 1 year ago

wetterskan commented 1 year ago

Preliminary checklist

Can the bug be reproduced with corresponding Chromium version?

Yes

Cromite version

117.0.5938.89

Device architecture

arm

Platform version

Android 12.1

Android Device model

Xiaomi Mi 10T (M2007J3SY, apollon)

Is the device rooted?

Yes

Changed flags

no flags changed

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

  1. No.

Describe the bug

The problem is happening in Pony Town. I can't get to any server because of a Game Maker error on which this game Pony Town is written: Failed to execute 'getGamepads' on 'Navigator': Access to the feature "gamepad" is denied

Steps to reproduce the bug

Sequence of actions:

  1. Log in to your Pony Town account or register it using the suggested social networks (icon in the upper right corner); 1.1. If there is no login, but registration, then the game will offer to enter a new nickname for the account;
  2. After logging in / registering, a character management window will appear, at the top of which, in the input field, you must enter any name / name of the new character;
  3. A large green "Save & Play" button will appear under the control window, you need to click on it to get to a random server. However, this will not happen in Cromite due to the Game Maker error described above, this error will appear on a red background, right under the green button. As a result, it is impossible to play.

Expected behavior

After clicking the green button, instead of the above error, you should get to the server. To be more specific, immediately after clicking on the green button, your character will appear on a large forest map along with the rest of the players who have joined, the game interface and control/interaction buttons with both your character and the others will also appear, located at the bottom and left. You will immediately be able to move around the map using an unfixed virtual joystick following your finger. This should be the case and it happens in any browser known to me, EXCEPT Cromite, in which this error does not allow you to log in to the server and play. WebGL and other permissions have been granted, and the adblock has also been disabled.

Screenshots

NONE

wetterskan commented 1 year ago

This is how the main menu of the game looks before logging on to the server:

Details

![Screenshot_20230921-223941_Fulguris](https://github.com/uazo/cromite/assets/96207548/bab7e80a-e2cb-4958-b401-d82786b4b4a9)

This is what a successful login to the server looks like in any browser except Cromite:

Details

![Screenshot_20230921-223030_Pony Town](https://github.com/uazo/cromite/assets/96207548/4df3e64a-b55d-4b8f-88ff-9a5338a9fdf9)

This is what an unsuccessful login to the server looks like only in Cromite:

Details

![Screenshot_20230921-223055_Cromite](https://github.com/uazo/cromite/assets/96207548/63ca6759-c514-46bd-bb67-2db6df5d333b)

uazo commented 1 year ago

This should be the case and it happens in any browser known to me, EXCEPT Cromite, in which this error does not allow you to log in to the server and play.

what can you do? we are special :)

joking aside, getGamepads is disabled by default under flag 'chrome://flags/#restrict-gamepad-access' patch My advice, however, is not to enable it, because it is a source of fingerprinting without any user control. I could have put it under site-settings, but I didn't think anyone would use it!

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale as there has been no recent activity in response to our request for more information. Please respond so that we can proceed with this issue.

Noir16 commented 9 months ago

My advice, however, is not to enable it, because it is a source of fingerprinting without any user control. I could have put it under site-settings, but I didn't think anyone would use it!

I recently needed this feature myself. I'd like to see it disabled by default, but modifiable in flags. Yes, I know it's bad for privacy, but WebGL and related features are being used in some web environments as a second Flash. Sure, it seems like the A**be Flash Player nightmare is repeating itself, but the fact remains that we need options because we can't do anything if we can't adapt to the environment.

uazo commented 9 months ago

but modifiable in flags

yes, you are right.

Yes, I know it's bad for privacy,

I still advise you not to leave the gamepad connected.